From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: /lib/cpp not found in c-mode Date: Sun, 08 May 2005 17:18:44 -0400 Message-ID: <87acn5ju96.fsf-monnier+emacs@gnu.org> References: <17013.26868.207510.370151@farnswood.snap.net.nz> <17013.52411.51878.781739@farnswood.snap.net.nz> <17014.39042.74353.677362@farnswood.snap.net.nz> <87d5s8144e.fsf@zemdatav.stor.no-ip.org> <17017.13673.613123.524633@farnswood.snap.net.nz> <87ll6tn4hh.fsf-monnier+emacs@gnu.org> <01c5519b$Blat.v2.4$0c9b1d00@zahav.net.il> <17018.35323.755067.631608@farnswood.snap.net.nz> <01c55238$Blat.v2.4$0e1c2960@zahav.net.il> <87ll6pk4o0.fsf-monnier+emacs@gnu.org> <01c55400$Blat.v2.4$9e886800@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1115588281 27065 80.91.229.2 (8 May 2005 21:38:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 8 May 2005 21:38:01 +0000 (UTC) Cc: mange@freemail.hu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 08 23:37:59 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DUtSn-0000Qw-E4 for ged-emacs-devel@m.gmane.org; Sun, 08 May 2005 23:37:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUtYQ-0004kM-7Y for ged-emacs-devel@m.gmane.org; Sun, 08 May 2005 17:43:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DUtX0-0004DC-3t for emacs-devel@gnu.org; Sun, 08 May 2005 17:41:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DUtWx-0004Ca-VE for emacs-devel@gnu.org; Sun, 08 May 2005 17:41:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DUtUZ-0003CB-5H for emacs-devel@gnu.org; Sun, 08 May 2005 17:39:15 -0400 Original-Received: from [209.226.175.25] (helo=tomts5-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DUtGX-000341-Qx; Sun, 08 May 2005 17:24:46 -0400 Original-Received: from alfajor ([67.71.32.212]) by tomts5-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050508211845.JPZP26128.tomts5-srv.bellnexxia.net@alfajor>; Sun, 8 May 2005 17:18:45 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id 905E0D72FB; Sun, 8 May 2005 17:18:44 -0400 (EDT) Original-To: Eli Zaretskii In-Reply-To: <01c55400$Blat.v2.4$9e886800@zahav.net.il> (Eli Zaretskii's message of "Sun, 08 May 2005 22:02:25 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36882 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36882 >> Actually, looking at the definition of executable-find, I'm surprised it >> doesn't use locate-file. > IIRC, executable-find was in existence longe before you added > locate-file. Yes, what I meant was that I was surprised I didn't change executable-find back when I added locate-file (especially since I had added exec-suffixes not that long before IIRC). >> The new code is nothing else than a call to locate-file and I'd argue >> that Eli's change from executable-find to locate-file is a bad idea and >> instead we should simply move executable-find from executable.el to >> subr.el. > Well, if you are going to use integer values as the last arg to > locate-file (which is deprecated usage, as the doc string says), why > not call locate-file-internal directly and save a few cycles? I could but the intention of using an integer arg wasn't to speed things up but to more closely match the behavior of call-process and start-process. > Also, I think this should go into files.el, not subr.el, since > locate-file is in files.el. Good point. Stefan