Re: Bug that needs fixing

Re: Bug that needs fixing

[Jason Rumney]

Stefan Monnier wrote:

>--- orig/lisp/net/ange-ftp.el
>+++ mod/lisp/net/ange-ftp.el
>@@ -729,7 +729,15 @@
> 	  "^local:\\|^Trying\\|^125 \\|^550-\\|^221 .*oodbye\\|"
>           "^500 .*AUTH \\(KERBEROS\\|GSSAPI\\)\\|^KERBEROS\\|"
> 	  "^530 Please login with USER and PASS\\|" ; non kerberised vsFTPd
>-	  "^22[789] .*[Pp]assive\\|^200 EPRT\\|^500 .*EPRT")
>+	  "^22[789] .*[Pp]assive\\|^200 EPRT\\|^500 .*EPRT\\|"
>+          ;; On Mac OS X we sometimes get things like:
>+          ;; 
>+          ;;     ftp> open ftp.nluug.nl
>+          ;;     Trying 2001:610:1:80aa:192:87:102:36...
>+          ;;     ftp: connect to address 2001:610:1:80aa:192:87:102:36: No route to host
>+          ;;     Trying 192.87.102.36...
>+          ;;     Connected to ftp.nluug.nl.
>+          "^ftp: connect to address .*: No route to host")
>  
>
Shouldn't all responses that do not start with a status code be ignored?

ie

"^[^1-9][^0-9][^0-9]"

or are there non-standard ftp servers that we have to parse 
status-code-less responses from?

Re: Bug that needs fixing

[Michael Albinus]

Jason Rumney <jasonr@gnu.org> writes:

> Shouldn't all responses that do not start with a status code be ignored?
>
> ie
>
> "^[^1-9][^0-9][^0-9]"

I fear that something like the response of the "dir" command shouldn't
be ignored.

Best regards, Michael.

Re: Bug that needs fixing

[Jason Rumney]

[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

Michael Albinus wrote:

>Jason Rumney <jasonr@gnu.org> writes:
>
>  
>
>>Shouldn't all responses that do not start with a status code be ignored?
>>
>>ie
>>
>>"^[^1-9][^0-9][^0-9]"
>>    
>>
>
>I fear that something like the response of the "dir" command shouldn't
>be ignored.
>  
>
Sure, but that is immediately preceded by a line with a 150 status code. 
I was assuming that data responses were handled separately than the 
protocol level chit-chat and wouldn't be affected by such a change.


[-- Attachment #1.2: Type: text/html, Size: 953 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Bug that needs fixing

[Michael Welsh Duggan]

Jason Rumney <jasonr@gnu.org> writes:

> Shouldn't all responses that do not start with a status code be ignored?
>
> ie
>
> "^[^1-9][^0-9][^0-9]"

Be careful when negating regexps, as this is seldom as easy as it
seems.  An actual negation of "^[1-9][1-9][1-9]" would be:
"^\\([^1-9]\\|[1-9][^1-9]\\|[1-9][1-9][^1-9]\\)".

-- 
Michael Welsh Duggan
(md5i@cs.cmu.edu)