From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: [david.hansen@physik.fu-berlin.de: WoMan Bug] Date: Sat, 23 Sep 2006 06:38:22 +0200 Organization: disorganized Message-ID: <87ac4r9ozl.fsf@robotron.kosmorama> References: <87wt87vz03.fsf@cs.cmu.edu> <87k645r8uz.fsf@cs.cmu.edu> <87bqphr7qo.fsf@cs.cmu.edu> <87zmcw4vo3.fsf@robotron.kosmorama> <87y7scpptc.fsf@furball.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158987244 15495 80.91.229.2 (23 Sep 2006 04:54:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 23 Sep 2006 04:54:04 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 23 06:54:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GQzWW-0000GI-18 for ged-emacs-devel@m.gmane.org; Sat, 23 Sep 2006 06:53:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GQzWV-0004SG-HV for ged-emacs-devel@m.gmane.org; Sat, 23 Sep 2006 00:53:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GQzWM-0004SB-AO for emacs-devel@gnu.org; Sat, 23 Sep 2006 00:53:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GQzWK-0004Rz-PE for emacs-devel@gnu.org; Sat, 23 Sep 2006 00:53:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GQzWK-0004Rw-Ly for emacs-devel@gnu.org; Sat, 23 Sep 2006 00:53:44 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GQzaD-0000YT-HY for emacs-devel@gnu.org; Sat, 23 Sep 2006 00:57:45 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GQzW9-0000D4-80 for emacs-devel@gnu.org; Sat, 23 Sep 2006 06:53:33 +0200 Original-Received: from e178042204.adsl.alicedsl.de ([85.178.42.204]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Sep 2006 06:53:33 +0200 Original-Received: from david.hansen by e178042204.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Sep 2006 06:53:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-To: emacs-devel@gnu.org Original-Lines: 70 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: e178042204.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:P93hlwE0z93GFunhXNKCjMXcM5I= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60128 Archived-At: On Thu, 21 Sep 2006 23:01:35 -0400 Chong Yidong wrote: > David Hansen writes: > >> On Sat, 16 Sep 2006 13:58:39 -0400 Stefan Monnier wrote: >> >>> I believe the patch below catches all the places where the problem could >>> have shown up. Can someone check that it makes sense and works? >> >> Hmm, against which version of woman i have to apply this >> patch? Can't get it to work with a fresh updated emacs. > > Works for me. I doubt. It even has unbalanced parens. But with a patched patch it's rendering the screen man page (please check. I only did the obvious stuff to get it compiled w/o warnings). *** /home/dhansen/.emacs.d/saves/!home!dhansen!woman.el.~1~ 2006-09-23 06:10:16.000000000 +0200 --- /home/dhansen/share/emacs/22.0.50/lisp/woman.el 2006-09-23 06:24:46.000000000 +0200 *************** *** 2657,2665 **** (error "File `%s' not found" name)) (beginning-of-line) (woman-delete-line 1) ! (let ((from (point)) ! (length (woman-insert-file-contents filename 0)) ! (to (copy-marker (+ from length) t))) (woman-pre-process-region from to) (set-marker to nil) (goto-char from) --- 2657,2665 ---- (error "File `%s' not found" name)) (beginning-of-line) (woman-delete-line 1) ! (let* ((from (point)) ! (length (woman-insert-file-contents filename 0)) ! (to (copy-marker (+ from length) t))) (woman-pre-process-region from to) (set-marker to nil) (goto-char from) *************** *** 3971,3984 **** (delete-char 1) (looking-at "\\(.\\)\\(.*\\)\\1") (forward-char 1) ! (let* ((to (match-end 2))) (from (match-beginning 0)) (N (woman-parse-numeric-arg)) (c (if (< (point) to) (following-char) ?_))) (delete-region from to) (delete-char 1) ! (insert (make-string N c)) ! )) ;;; 4. Text Filling, Adjusting, and Centering --- 3971,3983 ---- (delete-char 1) (looking-at "\\(.\\)\\(.*\\)\\1") (forward-char 1) ! (let* ((to (match-end 2)) (from (match-beginning 0)) (N (woman-parse-numeric-arg)) (c (if (< (point) to) (following-char) ?_))) (delete-region from to) (delete-char 1) ! (insert (make-string N c)))) ;;; 4. Text Filling, Adjusting, and Centering