From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luca Capello Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; [message-send-mail-function] wrong description and regression Date: Wed, 21 Nov 2007 01:30:13 +0100 Message-ID: <87abp8h23u.fsf@gismo.pca.it> References: <87d4u5jcje.fsf@gismo.pca.it> Reply-To: emacs-pretest-bug@gnu.org, Luca Capello NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1195605036 14606 80.91.229.12 (21 Nov 2007 00:30:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2007 00:30:36 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 21 01:30:41 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IudUE-0002LX-9n for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2007 01:30:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IudU0-0000Bq-AN for ged-emacs-devel@m.gmane.org; Tue, 20 Nov 2007 19:30:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IudTw-0000Bb-UR for emacs-devel@gnu.org; Tue, 20 Nov 2007 19:30:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IudTu-0000BK-Fq for emacs-devel@gnu.org; Tue, 20 Nov 2007 19:30:19 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IudTu-0000BH-Cf for emacs-devel@gnu.org; Tue, 20 Nov 2007 19:30:18 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IudTu-0003q8-2c for emacs-devel@gnu.org; Tue, 20 Nov 2007 19:30:18 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IudTt-00084D-Rf for emacs-pretest-bug@gnu.org; Tue, 20 Nov 2007 19:30:17 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IudTq-0003pU-GW for emacs-pretest-bug@gnu.org; Tue, 20 Nov 2007 19:30:17 -0500 Original-Received: from mbox.unige.ch ([129.194.9.209]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IudTp-0003pM-Vh for emacs-pretest-bug@gnu.org; Tue, 20 Nov 2007 19:30:14 -0500 Original-Received: from gismo.pca.it (21-93.203-62.cust.bluewin.ch [62.203.93.21]) by mbox.unige.ch (Sun Java(tm) System Messaging Server 6.3-1.04 (built May 9 2007; 32bit)) with ESMTPSA id <0JRT0035AYQCJZ20@mbox.unige.ch> for emacs-pretest-bug@gnu.org; Wed, 21 Nov 2007 01:30:13 +0100 (CET) Original-Received: by gismo.pca.it (Postfix, from userid 1000) id 3FF0359FF7; Wed, 21 Nov 2007 01:30:13 +0100 (CET) Mail-followup-to: emacs-pretest-bug@gnu.org, Luca Capello In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83747 gmane.emacs.pretest.bugs:20326 Archived-At: Hi all! On Wed, 21 Nov 2007 01:11:50 +0100, Katsumi Yamaoka wrote: >>>>>> Andreas Schwab wrote: >> (defun message-send-mail-function () >> "Return suitable value for the variable `message-send-mail-function'." >> (cond ((and sendmail-program >> (executable-find program)) >> ^^^^^^^ >> Should be sendmail-program? > > This doesn't fix it. While `make bootstrap' I got: > > Compiling /Work/emacs/lisp/./mh-e/mh-show.el > In toplevel form: > mh-e/mh-show.el:43:1:Error: Symbol's value as variable is void: sendmail-program > > Maybe it should be: > > (defun message-send-mail-function () > "Return suitable value for the variable `message-send-mail-function'." > (cond ((and (boundp 'sendmail-program) sendmail-program) > (executable-find sendmail-program)) For me the *obvious* fix is the following: --8<---------------cut here---------------start------------->8--- Index: lisp/gnus/message.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/gnus/message.el,v retrieving revision 1.127 diff -u -r1.127 message.el --- lisp/gnus/message.el 9 Nov 2007 09:46:00 -0000 1.127 +++ lisp/gnus/message.el 21 Nov 2007 00:29:49 -0000 @@ -50,7 +50,7 @@ (require 'mml) (require 'rfc822) (require 'ecomplete) - +(require 'sendmail) (defgroup message '((user-mail-address custom-variable) (user-full-name custom-variable)) --8<---------------cut here---------------end--------------->8--- Loading the local and modified lisp/gnus/message.el instead of (require 'message) on an `emacs -Q` clearly sets `message-send-mail-function' to the documentation default value `message-send-mail-with-sendmail'. Thx, bye, Gismo / Luca