Re: unicode build: "comparison is always true" warnings

[mah@everybody.org (Mark A. Hershberger)]

Andreas Schwab <schwab@suse.de> writes:

> mah@everybody.org (Mark A. Hershberger) writes:
>
>>        while (1)
>>  	{
>>  	  /* Create the lock file, but not under the lock file name.  */
>>  	  /* Give up if cannot do that.  */
>> +#ifndef HAVE_MKSTEMP
>>  	  desc = open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666);
>> +#else
>> +          desc = mkstemp (tempname);
>> +#endif
>
> That won't work since mkstemp modifies tempname in place, but can be
> called more than once here (the second call will return with EINVAL).

There is only one call.

If you look at the full patch, mktemp (not mkstemp) is called once if
HAVE_MKSTEMP is _not_ defined.  Here, mkstemp (not mktemp) is called if
HAVE_MKSTEMP _is_ defined.

Mark.

-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it