From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dave Goel Newsgroups: gmane.emacs.devel Subject: Re: Fixing numerous `message' bugs.. Date: Mon, 10 Dec 2007 15:31:12 -0500 Message-ID: <87aboijnqn.fsf@marie.gnufans.net> References: <87myso8yrs.fsf@marie.gnufans.net> <87ve7b4xt6.fsf@marie.gnufans.net> <85abonpxnw.fsf@lola.goethe.zz> <85fxyel8o8.fsf@lola.goethe.zz> <87hciugzal.fsf@marie.gnufans.net> <87ir36o3as.fsf@marie.gnufans.net> <475D7F91.80503@gnu.org> <877ijmmkuq.fsf@marie.gnufans.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1197318717 5177 80.91.229.12 (10 Dec 2007 20:31:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2007 20:31:57 +0000 (UTC) Cc: emacs-devel@gnu.org, Dave Goel , Jason Rumney To: Andreas Schwab , Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 10 21:32:08 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J1pIJ-0004sf-Jd for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 21:32:03 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1pI2-0000C5-0W for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 15:31:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1pHq-00006f-8F for emacs-devel@gnu.org; Mon, 10 Dec 2007 15:31:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1pHl-0008WQ-IP for emacs-devel@gnu.org; Mon, 10 Dec 2007 15:31:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1pHl-0008WL-CE for emacs-devel@gnu.org; Mon, 10 Dec 2007 15:31:29 -0500 Original-Received: from mtao02.charter.net ([209.225.8.187]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J1pHe-0001RB-2j; Mon, 10 Dec 2007 15:31:22 -0500 Original-Received: from aarprv06.charter.net ([10.20.200.76]) by mtao02.charter.net (InterMail vM.7.08.03.00 201-2186-126-20070710) with ESMTP id <20071210203118.ESDT27011.mtao02.charter.net@aarprv06.charter.net>; Mon, 10 Dec 2007 15:31:18 -0500 Original-Received: from marie.gnufans.net ([66.168.196.121]) by aarprv06.charter.net with ESMTP id <20071210203118.YFT14098.aarprv06.charter.net@marie.gnufans.net>; Mon, 10 Dec 2007 15:31:18 -0500 Original-Received: from deego by marie.gnufans.net with local (Exim 3.36 #1 (Debian)) id 1J1pHU-0002D4-00; Mon, 10 Dec 2007 15:31:12 -0500 X-Face: #5@=vrmx5t3mZaPY8(mR.n+V#:%4NW7j5A&^}@lGp2rK; CQ4%iH1v'gh/^A)w5*6c&R2(P' 4+seYDq8OK'LPI/C(C^A*w|f*t+8, 'T8b#_0~h3!A7GoVroE[cr0Fb'A0%SdU|Lk@gBV&1vA In-Reply-To: (Andreas Schwab's message of "Mon, 10 Dec 2007 20:56:05 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Chzlrs: 0 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84975 Archived-At: --=-=-= Andreas Schwab writes: > want to use EQ instead anyway, since you are comparing with a symbol. Thanks. Attached is a new patch, which also seems much more elegant. I am not a C expert. Can some one comment on it? Shall I commit it? I have tested it in these ways, and it seems to implement the suggested functionality completely. (message t) nil (message t nil) nil (message t "%s") "%s" We changed args[0], Is the value intact? -- (let ((a t)) (message a) a) t (message t "%%") "%%" (message "%%") "%" (message t nil 1 2 3 4 ) nil (message t "a" 1 2 3 4 ) "a" (message "%s" 1 2 3 4 ) "1" ---- --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=editfns.c.diff200711 Content-Transfer-Encoding: base64 LS0tIGJhY2t1cC9lZGl0Zm5zLTIwMDcxMTIzLTA4MjUtMjMtLS0yMDA3MTIxMC0xMTM1LTA3LmMJ MjAwNy0xMS0yMyAwODoyNToyMy4wMDAwMDAwMDAgLTA1MDAKKysrIGVkaXRmbnMuYwkyMDA3LTEy LTEwIDE1OjIzOjUxLjAwMDAwMDAwMCAtMDUwMApAQCAtMzIyMSwxMSArMzIyMSwyMSBAQAogYW55 IGV4aXN0aW5nIG1lc3NhZ2U7IHRoaXMgbGV0cyB0aGUgbWluaWJ1ZmZlciBjb250ZW50cyBzaG93 LiAgU2VlCiBhbHNvIGBjdXJyZW50LW1lc3NhZ2UnLgogCitJZiB0aGUgZmlyc3QgYXJndW1lbnQg aXMgdCwgdGhlIGZ1bmN0aW9uIGlzIGVxdWl2YWxlbnQgdG8gY2FsbGluZworKG1lc3NhZ2UgIiVz IiBzZWNvbmQtYXJndW1lbnQpLgorCiB1c2FnZTogKG1lc3NhZ2UgRk9STUFULVNUUklORyAmcmVz dCBBUkdTKSAgKi8pCiAgICAgIChuYXJncywgYXJncykKICAgICAgaW50IG5hcmdzOwogICAgICBM aXNwX09iamVjdCAqYXJnczsKIHsKKyAgLyogY2hlY2sgaWYgYXJnczA9PXQgKi8KKyAgaWYgKCFO SUxQKEZlcShhcmdzWzBdLFF0KSkpCisgICAgaWYgKE5JTFAgKGFyZ3NbMV0pIHx8IChuYXJncz09 MSkpCisgICAgICBhcmdzWzBdPVFuaWw7CisgICAgZWxzZQorICAgICAgYXJnc1swXT1idWlsZF9z dHJpbmcoIiVzIik7CisgIAogICBpZiAoTklMUCAoYXJnc1swXSkKICAgICAgIHx8IChTVFJJTkdQ IChhcmdzWzBdKQogCSAgJiYgU0JZVEVTIChhcmdzWzBdKSA9PSAwKSkK --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--