Re: Fixing numerous `message' bugs..

[Dave Goel <deego3@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

Andreas Schwab <schwab@suse.de> writes:


> want to use EQ instead anyway, since you are comparing with a symbol.

Thanks.  Attached is a new patch, which also seems much more elegant.  
I am not a C expert.  Can some one comment on it?  Shall I commit it?

I have tested it in these ways, and it seems to implement the
suggested functionality completely.

(message t)  
nil

(message t nil) 
nil

(message t "%s") 
"%s"

We changed args[0], Is the value intact? -- 

(let ((a t))
  (message a)
  a)    

t


(message t "%%")
"%%"

(message "%%")
"%"


(message t nil 1 2 3 4 ) 
nil



(message t "a" 1 2 3 4 ) 
"a"



(message "%s" 1 2 3 4 ) 
"1"




----


[-- Attachment #2: editfns.c.diff200711 --]
[-- Type: application/octet-stream, Size: 726 bytes --]

--- backup/editfns-20071123-0825-23---20071210-1135-07.c	2007-11-23 08:25:23.000000000 -0500
+++ editfns.c	2007-12-10 15:23:51.000000000 -0500
@@ -3221,11 +3221,21 @@
 any existing message; this lets the minibuffer contents show.  See
 also `current-message'.
 
+If the first argument is t, the function is equivalent to calling
+(message "%s" second-argument).
+
 usage: (message FORMAT-STRING &rest ARGS)  */)
      (nargs, args)
      int nargs;
      Lisp_Object *args;
 {
+  /* check if args0==t */
+  if (!NILP(Feq(args[0],Qt)))
+    if (NILP (args[1]) || (nargs==1))
+      args[0]=Qnil;
+    else
+      args[0]=build_string("%s");
+  
   if (NILP (args[0])
       || (STRINGP (args[0])
 	  && SBYTES (args[0]) == 0))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel