DocView broken!

DocView broken!

[Angelo Graziosi]

It seems that in current CVS 23.0.50 the DocVies is broken.

Now when I try to visit a PDF file in the minibuffer I see:


    File mode specification error: (void-function tramp-tramp-file-p)


and the file is shown as a text (Text mode).

Typing C-c C-c it says: undefined !!!

With the build I did yesterday it works fine.

This happens with Cygwin and GNU/Linux builds.


Cheers,
    Angelo.

---

Facesti come quei che va di notte,
che porta il lume dietro e se' non giova,
ma dopo se' fa le persone dotte.
---
                   DANTE, Purgatorio, xxii 67-69

Re: DocView broken!

[Tassilo Horn]

Angelo Graziosi <angelo.graziosi@alice.it> writes:

Hi Angelo,

> Now when I try to visit a PDF file in the minibuffer I see:
>
>    File mode specification error: (void-function tramp-tramp-file-p)
>
> and the file is shown as a text (Text mode).

Sorry, my bad.  I checked in a fix for this a minute ago.

Bye,
Tassilo

Re: DocView broken!

[Michael Albinus]

Tassilo Horn <tassilo@member.fsf.org> writes:

Hi Tassilo,

>> Now when I try to visit a PDF file in the minibuffer I see:
>>
>>    File mode specification error: (void-function tramp-tramp-file-p)
>>
>> and the file is shown as a text (Text mode).
>
> Sorry, my bad.  I checked in a fix for this a minute ago.

Your approach to require Tramp is not clean I fear. There are users
who don't use Tramp at all. Furthermore, tramp-tramp-file-p is not a
documented function, that means it could change without any notice.

Better would be to apply (file-remote-p buffer-file-name)

Furthermore, you shall check (stringp buffer-file-name) at all - try
"M-x doc-view-mode" when you are in *scratch* ...

> Bye,
> Tassilo

Best regards, Michael.

Re: DocView broken!

[Tassilo Horn]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Michael,

> Your approach to require Tramp is not clean I fear. There are users
> who don't use Tramp at all. Furthermore, tramp-tramp-file-p is not a
> documented function, that means it could change without any notice.
>
> Better would be to apply (file-remote-p buffer-file-name)

Ok, I'll change that.

> Furthermore, you shall check (stringp buffer-file-name) at all - try
> "M-x doc-view-mode" when you are in *scratch* ...

Right.

Thanks for the pointers,
Tassilo