From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails Date: Mon, 15 Sep 2008 15:48:24 +0200 Message-ID: <87abe91pw7.fsf@escher.local.home> References: <48CE1DF9.6020904@gmx.at> <87hc8h221x.fsf@escher.local.home> <48CE50FA.4030501@gmx.at> Reply-To: Stephen Berman , 886@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1221487704 6199 80.91.229.12 (15 Sep 2008 14:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Sep 2008 14:08:24 +0000 (UTC) Cc: 886@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 15 16:09:20 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KfEl2-0006Kw-J1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2008 16:08:52 +0200 Original-Received: from localhost ([127.0.0.1]:56194 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfEk1-0007vA-Oi for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2008 10:07:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KfEjp-0007nN-On for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 10:07:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KfEjp-0007mO-12 for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 10:07:37 -0400 Original-Received: from [199.232.76.173] (port=37422 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfEjo-0007mF-Qd for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 10:07:36 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46059) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KfEjo-0002jB-Gk for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 10:07:36 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8FE7Ywi015555; Mon, 15 Sep 2008 07:07:34 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8FDt4oo010051; Mon, 15 Sep 2008 06:55:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 15 Sep 2008 13:55:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 886 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 886-submit@emacsbugs.donarmstrong.com id=B886.12214865178055 (code B ref 886); Mon, 15 Sep 2008 13:55:04 +0000 Original-Received: (at 886) by emacsbugs.donarmstrong.com; 15 Sep 2008 13:48:37 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8FDmWLX008049 for <886@emacsbugs.donarmstrong.com>; Mon, 15 Sep 2008 06:48:34 -0700 Original-Received: (qmail invoked by alias); 15 Sep 2008 13:48:26 -0000 Original-Received: from i5387D3F5.versanet.de (EHLO escher.local.home) [83.135.211.245] by mail.gmx.net (mp059) with SMTP; 15 Sep 2008 15:48:26 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18W00EvEUsWU008sRRNdlHfwd0qarmWW07I94YDKx kjeHwiFkobLrhp Original-Received: by escher.local.home (Postfix, from userid 1000) id C43F01D10AD; Mon, 15 Sep 2008 15:48:24 +0200 (CEST) In-Reply-To: <48CE50FA.4030501@gmx.at> (martin rudalics's message of "Mon, 15 Sep 2008 14:11:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.62 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 15 Sep 2008 10:07:37 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20553 Archived-At: On Mon, 15 Sep 2008 14:11:38 +0200 martin rudalics wrote: >> Does the following patch fix it? >> >> *** emacs/lisp/info.el.~1.544.~ 2008-09-11 11:49:36.000000000 +0200 >> --- emacs/lisp/info.el 2008-09-15 11:22:53.000000000 +0200 >> *************** >> *** 3123,3129 **** >> (Info-goto-node >> (Info-extract-menu-item (match-string-no-properties 1)) fork) >> t))) >> ! (error "Point neither on reference nor in menu item description"))) >> >> ;; Common subroutine. >> (defun Info-try-follow-nearest-node (&optional fork) >> --- 3123,3130 ---- >> (Info-goto-node >> (Info-extract-menu-item (match-string-no-properties 1)) fork) >> t))) >> ! (unless (eq this-command 'Info-mouse-follow-nearest-node) >> ! (error "Point neither on reference nor in menu item description")))) >> >> ;; Common subroutine. >> (defun Info-try-follow-nearest-node (&optional fork) > > Yes - the following seems simpler: > > ! (eq this-command 'Info-mouse-follow-nearest-node) > ! (error "Point neither on reference nor in menu item description"))) Oops, yes of course. > I'm not sure though whether we should raise an error for mouse-2 clicks. > But I also fail to understand why we should raise an error at all. I agree an error here is unnecessary and it would be better to remove it. I doubt any existing code depends on it. Steve Berman