From: Chong Yidong <cyd@stupidchicken.com>
To: Juri Linkov <juri@jurta.org>
Cc: 3361@emacsbugs.donarmstrong.com, duanpanda@gmail.com,
emacs-devel@gnu.org
Subject: Re: 23.0.92; View-scroll-page-forward/backward does wrong in text mode after text-scale-increase/decrease
Date: Sun, 12 Jul 2009 12:44:08 -0400 [thread overview]
Message-ID: <87ab39onqf.fsf@stupidchicken.com> (raw)
In-Reply-To: <871von6jjk.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 11 Jul 2009 23:39:43 +0300")
Juri Linkov <juri@jurta.org> writes:
>> View-mode, written in the dawn of time, assumes that all lines have the
>> default height. The following patch changes it so that
>> scroll-up/scroll-down are passed nil arguments where possible; then
>> Emacs will automatically determine how to scroll by one page, taking
>> variable-height lines and text-scaling into account.
>>
>> It's not good to make this kind of change at this stage in the release,
>> but this bug would be pretty annoying if you happen to come across it,
>> and that's much more likely now we've introduced the text-scaling
>> commands. Could someone on emacs-devel help review the patch?
>
> I noticed that this patch causes a regression: typing RET used to put
> point to the last line at the end of the window, but now typing RET keeps
> point on the same line.
Thanks. This regression isn't serious enough for a fix in the branch, I
think (the docstring of View-scroll-line-forward does not say that point
should go to the last line). But I'll see what I can do for the trunk.
next prev parent reply other threads:[~2009-07-12 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 14:47 23.0.92; View-scroll-page-forward/backward does wrong in text mode after text-scale-increase/decrease Chong Yidong
2009-05-26 17:19 ` bug#3361: " Stefan Monnier
2009-05-26 17:19 ` Stefan Monnier
2009-07-11 20:39 ` Juri Linkov
2009-07-12 16:44 ` Chong Yidong [this message]
2009-07-12 21:02 ` Juri Linkov
2009-07-13 0:08 ` Miles Bader
2009-07-13 20:07 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab39onqf.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=3361@emacsbugs.donarmstrong.com \
--cc=duanpanda@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.