From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] org-occur requires a non-empty regexp for performance Date: Mon, 03 Aug 2009 02:59:24 +0800 Message-ID: <87ab2ij9er.fsf@bzg.ath.cx> References: <87skgb82cm.fsf@gimli.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXgqm-0004Ac-07 for emacs-orgmode@gnu.org; Sun, 02 Aug 2009 15:36:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXgqh-00048Z-AW for emacs-orgmode@gnu.org; Sun, 02 Aug 2009 15:36:07 -0400 Received: from [199.232.76.173] (port=42163 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXgqh-00048V-5h for emacs-orgmode@gnu.org; Sun, 02 Aug 2009 15:36:03 -0400 Received: from mail-px0-f194.google.com ([209.85.216.194]:55429) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXgqg-0002rp-OH for emacs-orgmode@gnu.org; Sun, 02 Aug 2009 15:36:02 -0400 Received: by pxi32 with SMTP id 32so1833622pxi.24 for ; Sun, 02 Aug 2009 12:36:01 -0700 (PDT) In-Reply-To: <87skgb82cm.fsf@gimli.intra.norang.ca> (Bernt Hansen's message of "Sat, 01 Aug 2009 20:51:37 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Bernt Hansen writes: > If a blank regexp is provided to org-occur the function > goes away for a l-o-n-g time. We'll just bail out > instead up front to prevent an infinite loop. > --- > I never actually let this run long enough to find out if > it is an infinite loop -- or if it just takes forever > to return results. I'm not that patient. > > This patch is available at git://git.norang.ca/org-mode.git > for-carsten Applied, thanks! -- Bastien