From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4429: purecopy calls needed for :help and in menu-bar.el Date: Tue, 03 Nov 2009 09:29:11 +0200 Organization: JURTA Message-ID: <87aaz4qd6h.fsf@mail.jurta.org> References: <200909141843.n8EIhIpg023585@godzilla.ics.uci.edu> <200909161050.n8GAoSZR011819@godzilla.ics.uci.edu> <877hux22uj.fsf@mail.jurta.org> <873a5kwb2j.fsf@mail.jurta.org> <200911030645.nA36j7QM019013@godzilla.ics.uci.edu> Reply-To: Juri Linkov , 4429@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257234458 32754 80.91.229.12 (3 Nov 2009 07:47:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2009 07:47:38 +0000 (UTC) Cc: 4429@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 08:47:30 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5E70-0004G0-GE for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2009 08:47:30 +0100 Original-Received: from localhost ([127.0.0.1]:59189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5E6z-0001h0-SF for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2009 02:47:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5E6u-0001gb-E6 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 02:47:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5E6p-0001eJ-Hd for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 02:47:23 -0500 Original-Received: from [199.232.76.173] (port=36196 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5E6p-0001eF-Do for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 02:47:19 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:34906) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N5E6o-0003aK-SJ for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 02:47:19 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5E6n-0001QO-PD for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2009 02:47:18 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA37lF5A005944; Mon, 2 Nov 2009 23:47:16 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nA37e4W8004860; Mon, 2 Nov 2009 23:40:04 -0800 Resent-Date: Mon, 2 Nov 2009 23:40:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 03 Nov 2009 07:40:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4429 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4429-submit@emacsbugs.donarmstrong.com id=B4429.12572334393971 (code B ref 4429); Tue, 03 Nov 2009 07:40:04 +0000 Original-Received: (at 4429) by emacsbugs.donarmstrong.com; 3 Nov 2009 07:30:39 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA37Ubxl003964 for <4429@emacsbugs.donarmstrong.com>; Mon, 2 Nov 2009 23:30:38 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.34.131.cable.starman.ee [82.131.34.131]) by mx1.starman.ee (Postfix) with ESMTP id 514C63F41B5; Tue, 3 Nov 2009 09:30:30 +0200 (EET) In-Reply-To: <200911030645.nA36j7QM019013@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 2 Nov 2009 22:45:07 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Tue, 03 Nov 2009 02:47:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32385 Archived-At: > > >> Does anyone know a reason why one menu item in menu-bar.el > > >> (`separator-exit') doesn't use the standard format with `menu-item' > > >> like all other menu items use? > > > > > > Accident? > > > > Probably. Fixed. > > I think that a better fix would be to purecopy '("--"), there are >60 > instances of this in GC memory right when emacs starts up. > > Maybe define a constant menu-bar-standard-separator and use that > everywhere? I think a constant for "--" is a good idea. BTW, I just added a quote in 3 calls of `menu-bar-make-mm-toggle' in menu-bar.el since this is necessary after your recent changes in `menu-bar-make-mm-toggle'. I hope that no code outside Emacs calls `menu-bar-make-mm-toggle'. Otherwise, it will be broken. -- Juri Linkov http://www.jurta.org/emacs/