From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sat, 27 Feb 2010 16:37:47 -0500 Message-ID: <87aauugy1g.fsf@stupidchicken.com> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83vddidh73.fsf@gnu.org> <83hbp2cxgx.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1267306681 28761 80.91.229.12 (27 Feb 2010 21:38:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2010 21:38:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 22:37:57 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlUMG-00057t-IO for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 22:37:56 +0100 Original-Received: from localhost ([127.0.0.1]:42492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlUMF-00060C-UH for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 16:37:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlUMA-0005z1-NJ for emacs-devel@gnu.org; Sat, 27 Feb 2010 16:37:50 -0500 Original-Received: from [140.186.70.92] (port=59170 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlUM9-0005yT-Va for emacs-devel@gnu.org; Sat, 27 Feb 2010 16:37:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlUM8-0007Mb-P5 for emacs-devel@gnu.org; Sat, 27 Feb 2010 16:37:49 -0500 Original-Received: from pantheon-po33.its.yale.edu ([130.132.50.94]:49962) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlUM8-0007MJ-N5; Sat, 27 Feb 2010 16:37:48 -0500 Original-Received: from furry (dhcp128036203168.central.yale.edu [128.36.203.168]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o1RLblvL013674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 27 Feb 2010 16:37:47 -0500 Original-Received: by furry (Postfix, from userid 1000) id 9B604C05D; Sat, 27 Feb 2010 16:37:47 -0500 (EST) In-Reply-To: <83hbp2cxgx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Feb 2010 21:03:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.93 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121456 Archived-At: Eli Zaretskii writes: > "bzr bisect" points to this change as the reason for this bug: > > 2010-02-05 Chong Yidong > > * charset.c (load_charset_map_from_file): Allocate large > charset_map_entries structure on the heap rather than the stack. > (Bug#5526). > > The revisions before this change works correctly; all revisions after > it fail as described above. Hmm, this is strange. This change (actually the succeeding 2010-02-06 change to the same place) switches from using alloca to SAFE_ALLOCA (i.e. malloc, since the desired structure is large). But the only way I can see for this code to crash is if load_charset_map somehow makes a pointer into the allocated structure. But in that case, the old alloca case should have crashed too. If you remove the SAFE_FREE () calls, does that prevent the crash?