From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Fri, 11 Jun 2010 08:46:26 +0200 Message-ID: <87aar22hj1.fsf@keller.adm.naquadah.org> References: <13588_1276211690_ZZh01350LoUj0.00_1276211773.5476.15.camel@localhost.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1276238810 26277 80.91.229.12 (11 Jun 2010 06:46:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 06:46:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jan Moringen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 11 08:46:49 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMy0t-0003u5-S1 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 08:46:48 +0200 Original-Received: from localhost ([127.0.0.1]:41320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMy0s-0004Kx-T3 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 02:46:46 -0400 Original-Received: from [140.186.70.92] (port=48672 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMy0h-0004Hn-Sj for emacs-devel@gnu.org; Fri, 11 Jun 2010 02:46:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMy0g-0007uW-Hd for emacs-devel@gnu.org; Fri, 11 Jun 2010 02:46:35 -0400 Original-Received: from prometheus.naquadah.org ([212.85.154.174]:36025 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMy0g-0007u9-CT for emacs-devel@gnu.org; Fri, 11 Jun 2010 02:46:34 -0400 Original-Received: by mx1.naquadah.org (Postfix, from userid 8) id ABC155C149; Fri, 11 Jun 2010 08:46:31 +0200 (CEST) Original-Received: from keller.adm.naquadah.org (chapai.naquadah.org [82.227.158.144]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id B95F75C11A; Fri, 11 Jun 2010 08:46:29 +0200 (CEST) Original-Received: from jd by keller.adm.naquadah.org with local (Exim 4.72) (envelope-from ) id 1OMy0b-00017g-6z; Fri, 11 Jun 2010 08:46:29 +0200 In-Reply-To: <13588_1276211690_ZZh01350LoUj0.00_1276211773.5476.15.camel@localhost.localdomain> (Jan Moringen's message of "Fri, 11 Jun 2010 01:16:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125719 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jun 11 2010, Jan Moringen wrote: > 1. Maybe the docstring should mention that :body and action name > strings can contain markup like bold and that the > notification does not display a string if it contains invalid > markup like text. I think, > `xml-escape-string' can be used to safely display strings that > may contain invalid markup. Yes, that'd be a good idea. And yes xml-escape-string is good for that. > 2. Older versions of libnotify seem to use a slightly different > interface: it seems like the signal for closing notifications > does not include a reason (see output of dbus-monitor [1]). I > suggest making the reason argument in the -on-closed handler > optional. Seems weird to me. Which version do you have? I've implemented version 0.9 of the spec here; there's still version 0.3 online, and even in that old version there's a reason in the ClosedNotification signal. So if this is real you might have a really really really old version? =2D-=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwR28IACgkQpGK1HsL+5c0iKgCffdeAmpaL+++2wsPcCKPYH6dp 2iwAn3vn1UV83G7tNoV4lisH8XIS06qA =x83+ -----END PGP SIGNATURE----- --=-=-=--