[BUG] org-timer requires org-notify from org-clock

[BUG] org-timer requires org-notify from org-clock

[Łukasz Stelmach]

Hello.

It seems like there has to be (require 'org-clock) on top of
org-timer.el because otherwise the notification lambda
in-org-timer-set-timer fails because org-notify is not defined and the
timer starts going forward after it passes 0:00:00. It also looks like

(declare-function org-notify "org-clock" (notification &optional
                  play-sound))

is not enough. (BTW. now its d-f org-show-notification which is not used
in org-timer). Simple

(require 'org-clock)

helps, as anything else that loads org-clock like clocking-in.

-- 
Miłego dnia,
Łukasz Stelmach

Re: [BUG] org-timer requires org-notify from org-clock

[Bastien]

Łukasz Stelmach <lukasz.stelmach@iem.pw.edu.pl> writes:

> It seems like there has to be (require 'org-clock) on top of
> org-timer.el because otherwise the notification lambda
> in-org-timer-set-timer fails because org-notify is not defined and the
> timer starts going forward after it passes 0:00:00. It also looks like
>
> (declare-function org-notify "org-clock" (notification &optional
>                   play-sound))
>
> is not enough. (BTW. now its d-f org-show-notification which is not used
> in org-timer). Simple
>
> (require 'org-clock)
>
> helps, as anything else that loads org-clock like clocking-in.

Fixed, thanks.

-- 
 Bastien