From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#7011: 24.1; [PATCH] improve eshell-remove-entries Date: Sun, 24 Oct 2010 13:25:00 -0400 Message-ID: <87aam3fqqb.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287942191 25763 80.91.229.12 (24 Oct 2010 17:43:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 24 Oct 2010 17:43:11 +0000 (UTC) Cc: John Wiegley , 7011@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 24 19:43:09 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PA4b5-0002le-Su for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Oct 2010 19:43:08 +0200 Original-Received: from localhost ([127.0.0.1]:51470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PA4b5-00080J-4c for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Oct 2010 13:43:07 -0400 Original-Received: from [140.186.70.92] (port=59268 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PA4av-0007yK-V2 for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2010 13:42:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PA4au-0007jr-SH for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2010 13:42:57 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PA4au-0007jl-Qj for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2010 13:42:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PA4Gf-00042B-TK; Sun, 24 Oct 2010 13:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2010 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7011 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7011-submit@debbugs.gnu.org id=B7011.128794086315474 (code B ref 7011); Sun, 24 Oct 2010 17:22:01 +0000 Original-Received: (at 7011) by debbugs.gnu.org; 24 Oct 2010 17:21:03 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA4Fj-00041X-62 for submit@debbugs.gnu.org; Sun, 24 Oct 2010 13:21:03 -0400 Original-Received: from pantheon-po16.its.yale.edu ([130.132.50.72]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA4Fg-00041B-7v for 7011@debbugs.gnu.org; Sun, 24 Oct 2010 13:21:00 -0400 Original-Received: from furball (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po16.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9OHOxfu009211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 24 Oct 2010 13:24:59 -0400 Original-Received: by furball (Postfix, from userid 1000) id 48E381607BF; Sun, 24 Oct 2010 13:25:00 -0400 (EDT) In-Reply-To: (Leo's message of "Sat, 11 Sep 2010 03:49:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 24 Oct 2010 13:22:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41113 Archived-At: Leo writes: > eshell-remove-entries implements its own recursive delete of files in a > directory and this does not play well with the move-to-trash feature. > For example, if you use 'rm -rf' in eshell to delete a dir with hundreds > of files in it (eg .git), you will get hundreds of files at the top > level of the Trash bin. > > The following patch enables eshell-remove-entries to support > move-to-trash feature and use delete-directory's RECURSIVE arg instead. Thanks. I've committed this patch, and your followup patch.