From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Mon, 02 May 2011 17:16:04 -0400 Message-ID: <87aaf4ajmz.fsf@stupidchicken.com> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> <87oc3kudag.fsf@lifelogs.com> <87zkn4sx43.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304370979 3511 80.91.229.12 (2 May 2011 21:16:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 May 2011 21:16:19 +0000 (UTC) Cc: Ted Zlatanov , emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 02 23:16:14 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QH0TV-0004XT-Dv for ged-emacs-devel@m.gmane.org; Mon, 02 May 2011 23:16:13 +0200 Original-Received: from localhost ([::1]:42681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH0TU-0004Jj-Uq for ged-emacs-devel@m.gmane.org; Mon, 02 May 2011 17:16:12 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH0TR-0004JR-Pg for emacs-devel@gnu.org; Mon, 02 May 2011 17:16:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QH0TR-0005ai-14 for emacs-devel@gnu.org; Mon, 02 May 2011 17:16:09 -0400 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]:60989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH0TQ-0005ae-Vf for emacs-devel@gnu.org; Mon, 02 May 2011 17:16:08 -0400 Original-Received: from furball (static-66-16-23-114.dsl.cavtel.net [66.16.23.114]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p42LG59s002882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 2 May 2011 17:16:06 -0400 Original-Received: by furball (Postfix, from userid 1000) id A9DAC1604EB; Mon, 2 May 2011 17:16:04 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Mon, 2 May 2011 21:53:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.144 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139004 Archived-At: Juanma Barranquero writes: > To be useful, gnutls-available-p should be used always. It's cleaner than > > (if (and (eq system-type 'w32) (gnutls-available-p)) ...) > > It's the same with the image libraries. Correct image code from elisp > should always do > > (if (image-type-available-p 'png) In the case of open-network-stream, why do you need to use gnutls-available-p? Why not either use `starttls', or do `tls' and then `network' if that fails? After all, gnutls not being available is only one of many possible failure modes, so it's better to just let open-network-stream handle them.