bug#10578: 24.0.92; No png images on OpenSUSE 12.1

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

I'm trying to compile Emacs 24 (current bzr) under OpenSUSE 12.1.
Everything seems to work fine except inserting PNG images.

If I do the following, I just get a blank square:

(insert-image (create-image "/music/repository/Arto Lindsay/Prize/thumbnail.png"))
t

If I insert a gif or a jpeg, things work fine.  If I try to insert
something that isn't an image at all, I get an error message.  But with
pngs, I don't get any error messages, and I don't get an image, just
that blank square.

The png libraries seem to exist:

larsi@linux-hvfx:~/src/emacs/trunk> ldd src/emacs | grep png
	libpng12.so.0 => /usr/lib/libpng12.so.0 (0xb7631000)
	libpng14.so.14 => /usr/lib/libpng14.so.14 (0xb656f000)
larsi@linux-hvfx:~/src/emacs/trunk> ls -l /usr/lib/libpng12.so.0 /usr/lib/libpng14.so.14
lrwxrwxrwx 1 root root 18 Dec  8 01:20 /usr/lib/libpng12.so.0 -> libpng12.so.0.46.0
lrwxrwxrwx 1 root root 18 Nov 10 17:25 /usr/lib/libpng14.so.14 -> libpng14.so.14.8.0

Is there any way to get more image debugging switched on?


In GNU Emacs 24.0.92.2 (i686-pc-linux-gnu, X toolkit)
 of 2012-01-22 on linux-hvfx.site
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<down-mouse-2> <mouse-2> <down-mouse-2> <mouse-2> <help-echo> 
C-y C-x C-e C-x 2 C-x C-f C-a C-k . <backspace> / m 
y <tab> r e <backspace> <backspace> <backspace> u s 
<tab> r e o p <tab> <backspace> <backspace> p o <tab> 
A r t o <tab> / P r <tab> <return> C-v C-x o <up> C-a 
C-k C-k C-y <return> C-y <up> C-e <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> x x x x x x <left> <left> <left> <left> <left> 
<left> M-d M-d d i s p l a y . j p e <backspace> g 
<down> C-u C-x C-e <up> <up> <up> <up> <up> <down> 
C-e <down> C-e <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> M-d t h u 
m b n a i l <down> <return> C-u C-x C-e C-v C-v C-v 
C-v <up> <up> <down> <down> <down> <down> <down> <down> 
C-x 1 C-v <up> <up> M-x a p e o <tab> <backspace> <backspace> 
r <tab> <return> p n g <return> M-x M-p <return> i 
m a g e . * d e b u g <return> M-x M-p <return> d e 
b u g . * i m a g e <return> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> M-x 
r e p o r t - e m <tab> <return>

Recent messages:
PNG warning: Application was compiled with png.h from libpng-1.4.8
PNG warning: Application  is  running with png.c from libpng-1.2.46
PNG error: Incompatible libpng version in application and library
Source file `/home/larsi/src/emacs/trunk/lisp/mail/emacsbug.el' newer than byte-compiled file
PNG warning: Application was compiled with png.h from libpng-1.4.8
PNG warning: Application  is  running with png.c from libpng-1.2.46
PNG error: Incompatible libpng version in application and library
PNG warning: Application was compiled with png.h from libpng-1.4.8
PNG warning: Application  is  running with png.c from libpng-1.2.46
PNG error: Incompatible libpng version in application and library

Load-path shadows:
~/lisp/zenirc-2.112/src/zenirc-example hides /home/larsi/lisp/zenirc-example
/home/larsi/src/cddb.el/expect hides /home/larsi/lisp/expect

Features:
(shadow sort message rfc822 mml mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils
gmm-utils mailheader emacsbug help-mode easymenu view apropos
tramp-cache tramp tramp-compat auth-source eieio byte-opt bytecomp
byte-compile cconv macroexp assoc gnus-util mm-util mail-prsvr
password-cache shell pcomplete comint ring format-spec tramp-loaddefs
debug uniquify advice help-fns advice-preload ido flyspell ispell dired
regexp-opt add-log mail-extr jka-compr cl time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image
fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer loaddefs button faces cus-face files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dynamic-setting
system-font-setting font-render-setting x-toolkit x multi-tty emacs)

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 22 Jan 2012 17:12:18 +0100
> 
> I'm trying to compile Emacs 24 (current bzr) under OpenSUSE 12.1.
> Everything seems to work fine except inserting PNG images.
> 
> If I do the following, I just get a blank square:
> 
> (insert-image (create-image "/music/repository/Arto Lindsay/Prize/thumbnail.png"))
> t
> 
> If I insert a gif or a jpeg, things work fine.  If I try to insert
> something that isn't an image at all, I get an error message.  But with
> pngs, I don't get any error messages, and I don't get an image, just
> that blank square.

Yes you do:

> Recent messages:
> PNG warning: Application was compiled with png.h from libpng-1.4.8
> PNG warning: Application  is  running with png.c from libpng-1.2.46
> PNG error: Incompatible libpng version in application and library

Any questions?

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Magne Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Recent messages:
>> PNG warning: Application was compiled with png.h from libpng-1.4.8
>> PNG warning: Application  is  running with png.c from libpng-1.2.46
>> PNG error: Incompatible libpng version in application and library
>
> Any questions?

Of course.

1) Why didn't the warnings appear in the echo area instead of just
hiding out in the *Messages* buffer?

2) If I have both libpng12 and 14 installed, why is Emacs building
against 14 and then preferring 12 when running?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Achim Gratz]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 2) If I have both libpng12 and 14 installed, why is Emacs building
> against 14 and then preferring 12 when running?

I think I know that one: you have libpng14-devel installed, but not
libpng12-devel and libpng12-compat-devel...


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Andreas Schwab]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> 2) If I have both libpng12 and 14 installed, why is Emacs building
> against 14 and then preferring 12 when running?

Your emacs is linked (indirectly) against both versions.  Which of the
libpng14-devel, libpng14-compat-devel, libpng12-devel,
libpng12-compat-devel packages do you have installed?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Your emacs is linked (indirectly) against both versions.  Which of the
> libpng14-devel, libpng14-compat-devel, libpng12-devel,
> libpng12-compat-devel packages do you have installed?

I had, let's see...

These three: libpng14-devel libpng12-devel libpng12-compat-devel

When I removed libpng12-devel, libpng12-compat-devel was also removed,
and libpng14-compat-devel was installed, and things started working on
that OpenSUSE machine.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Cc: 10578@debbugs.gnu.org
> Date: Sun, 22 Jan 2012 17:50:02 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Recent messages:
> >> PNG warning: Application was compiled with png.h from libpng-1.4.8
> >> PNG warning: Application  is  running with png.c from libpng-1.2.46
> >> PNG error: Incompatible libpng version in application and library
> >
> > Any questions?
> 
> Of course.
> 
> 1) Why didn't the warnings appear in the echo area instead of just
> hiding out in the *Messages* buffer?

Most probably because they are emitted during redisplay, and you
cannot have anything displayed in the echo area at redisplay time,
because doing so re-enters redisplay, which will again produce the
same error message, etc., ad nauseam (a.k.a. infloop).

> 2) If I have both libpng12 and 14 installed, why is Emacs building
> against 14 and then preferring 12 when running?

Because Emacs on GNU/Linux doesn't use the kind of machinery it does
on MS-Windows, whereby it will reject 12 if it was compiled against
14.  See w32-win.el:dynamic-library-alist, and in particular how it
consults the variable libpng-version (which is set at compile time).

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> Date: Sun, 22 Jan 2012 19:51:40 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 10578@debbugs.gnu.org
> 
> > 1) Why didn't the warnings appear in the echo area instead of just
> > hiding out in the *Messages* buffer?
> 
> Most probably because they are emitted during redisplay, and you
> cannot have anything displayed in the echo area at redisplay time,
> because doing so re-enters redisplay, which will again produce the
> same error message, etc., ad nauseam (a.k.a. infloop).

The message is logged by image_error that has this commentary:

  /* Log error message with format string FORMAT and argument ARG.
     Signaling an error, e.g. when an image cannot be loaded, is not a
     good idea because this would interrupt redisplay, and the error
     message display would lead to another redisplay.  This function
     therefore simply displays a message.  */

(That last "displays" should be "logs".)

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Sun, Jan 22, 2012 at 19:12, Eli Zaretskii <eliz@gnu.org> wrote:

> The message is logged by image_error that has this commentary:
>
>  /* Log error message with format string FORMAT and argument ARG.
>     Signaling an error, e.g. when an image cannot be loaded, is not a
>     good idea because this would interrupt redisplay, and the error
>     message display would lead to another redisplay.  This function
>     therefore simply displays a message.  */
>
> (That last "displays" should be "logs".)

Couldn't that simply set a warning in `delayed-warnings-list'? It
would cause a warning at post-command-hook time.

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sun, 22 Jan 2012 20:32:55 +0100
> Cc: larsi@gnus.org, 10578@debbugs.gnu.org
> 
> On Sun, Jan 22, 2012 at 19:12, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > The message is logged by image_error that has this commentary:
> >
> >  /* Log error message with format string FORMAT and argument ARG.
> >     Signaling an error, e.g. when an image cannot be loaded, is not a
> >     good idea because this would interrupt redisplay, and the error
> >     message display would lead to another redisplay.  This function
> >     therefore simply displays a message.  */
> >
> > (That last "displays" should be "logs".)
> 
> Couldn't that simply set a warning in `delayed-warnings-list'? It
> would cause a warning at post-command-hook time.

How about if you try doing that?

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Sun, Jan 22, 2012 at 21:41, Eli Zaretskii <eliz@gnu.org> wrote:

> How about if you try doing that?

Can you give me a simple recipe for generating a redisplay warning / error?

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Sun, Jan 22, 2012 at 22:25, Juanma Barranquero <lekktu@gmail.com> wrote:

> Can you give me a simple recipe for generating a redisplay warning / error?

OK, forget it. I'll use the recipe from the OP.

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Sun, Jan 22, 2012 at 21:41, Eli Zaretskii <eliz@gnu.org> wrote:

> How about if you try doing that?

The simplest way is just to warn with a fixed message, as in the attached patch.

If we want to warn with the real message for image_error, either we
duplicate the Fformat call in add_to_log, which seems a waste, or we
add some function xdisp.c:add_to_log_and_warn. Alternatively,
repurposing add_to_log to also (optionally) warn wouldn't be
difficult, as it is used only nine times in the sources.

In any case, that kind of warning can be intrusive, because
display-warning keeps displaying the *Warnings* buffer. For example,
if I load libpng12 in a png14-compiled Emacs and visit a PNG file, I
get a string of 9 warnings, and 3 more each time I try to advance the
cursor. I think it wouldn't be much of a problem with image_error,
because the errors are caused by displaying images, and as soon as you
kill the corresponding buffer you're OK.

    Juanma


=== modified file 'src/image.c'
--- src/image.c	2012-01-19 07:21:25 +0000
+++ src/image.c	2012-01-22 22:22:31 +0000
@@ -676,7 +676,14 @@
 static void
 image_error (const char *format, Lisp_Object arg1, Lisp_Object arg2)
 {
+  Lisp_Object warning[3];
+
   add_to_log (format, arg1, arg2);
+  warning[0] = intern ("image");
+  warning[1] = build_string ("Image error, please check *Messages*");
+  warning[2] = intern (":error");
+  Vdelayed_warnings_list = Fcons (Flist (3, warning),
+                                  Vdelayed_warnings_list);
 }

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Juanma Barranquero <lekktu@gmail.com> writes:

> The simplest way is just to warn with a fixed message, as in the
> attached patch.

I think that's a good approach.

> In any case, that kind of warning can be intrusive, because
> display-warning keeps displaying the *Warnings* buffer. For example,
> if I load libpng12 in a png14-compiled Emacs and visit a PNG file, I
> get a string of 9 warnings, and 3 more each time I try to advance the
> cursor. I think it wouldn't be much of a problem with image_error,
> because the errors are caused by displaying images, and as soon as you
> kill the corresponding buffer you're OK.

Perhaps it would be an idea to add a simple rate-limiting device?  That
is, don't output the "Look in the *Messages* buffer" more often than,
say, once per second.  Or minute.  Perhaps per ten seconds makes more
sense, so that the message isn't as easily lost, but makes it possible
to continue using Emacs.

[...]

> +  warning[0] = intern ("image");
> +  warning[1] = build_string ("Image error, please check *Messages*");
> +  warning[2] = intern (":error");
> +  Vdelayed_warnings_list = Fcons (Flist (3, warning),
> +                                  Vdelayed_warnings_list);

And perhaps just factor it out into its own function, and just say
"Display error, please check *Messages*", and then all redisplay code
that outputs error messages in this manner can use it to alert the user
about this?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Wed, Jan 25, 2012 at 20:31, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Perhaps it would be an idea to add a simple rate-limiting device?  That
> is, don't output the "Look in the *Messages* buffer" more often than,
> say, once per second.  Or minute.  Perhaps per ten seconds makes more
> sense, so that the message isn't as easily lost, but makes it possible
> to continue using Emacs.

In the attached patch, the warning is shown after 5 seconds of idle
time. Also, all warnings of type `display' are assumed to be
equivalent and only the most recent one is displayed; the rest are
discarded.

    Juanma



=== modified file 'lisp/subr.el'
--- lisp/subr.el	2012-01-23 02:10:36 +0000
+++ lisp/subr.el	2012-01-26 04:23:06 +0000
@@ -1879,7 +1879,31 @@
         (push warning collapsed)))
     (setq delayed-warnings-list (nreverse collapsed))))

+(defconst display-errors-idle-time 5.0
+  "Interval of idle time before warning about display errors.")
+
+(defvar display-errors-pending nil
+  "Internal use only.")
+
+(defun show-display-errors-when-idle ()
+  "Warn about display errors when Emacs is idle.
+Only the most recent error (possibly collapsed) is shown,
+after `display-errors-idle-time' seconds of idle time;
+the rest are assumed to be identical and discarded.
+Used from `delayed-warnings-hook' (which see)."
+  (let ((display-error (assq 'display delayed-warnings-list)))
+    (when display-error
+      (setq delayed-warnings-list (assq-delete-all 'display
+                                                   delayed-warnings-list))
+      (unless display-errors-pending
+        (setq display-errors-pending display-error)
+        (run-with-idle-timer display-errors-idle-time nil
+                             (lambda ()
+                               (apply 'display-warning display-errors-pending)
+                               (setq display-errors-pending nil)))))))
+
 (defvar delayed-warnings-hook '(collapse-delayed-warnings
+                                show-display-errors-when-idle
                                 display-delayed-warnings)
   "Normal hook run to process delayed warnings.
 Functions in this hook should access the `delayed-warnings-list'

=== modified file 'src/image.c'
--- src/image.c	2012-01-19 07:21:25 +0000
+++ src/image.c	2012-01-26 04:02:24 +0000
@@ -677,6 +677,7 @@
 image_error (const char *format, Lisp_Object arg1, Lisp_Object arg2)
 {
   add_to_log (format, arg1, arg2);
+  warn_about_display_error ();
 }



=== modified file 'src/lisp.h'
--- src/lisp.h	2012-01-19 07:21:25 +0000
+++ src/lisp.h	2012-01-26 04:02:15 +0000
@@ -2746,6 +2746,7 @@
 extern void redisplay (void);
 extern void redisplay_preserve_echo_area (int);
 extern void prepare_menu_bars (void);
+extern void warn_about_display_error (void);

 void set_frame_cursor_types (struct frame *, Lisp_Object);
 extern void syms_of_xdisp (void);

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2012-01-19 07:21:25 +0000
+++ src/xdisp.c	2012-01-26 04:03:05 +0000
@@ -2326,6 +2326,7 @@
 safe_eval_handler (Lisp_Object arg)
 {
   add_to_log ("Error during redisplay: %S", arg, Qnil);
+  warn_about_display_error ();
   return Qnil;
 }

@@ -10612,6 +10613,18 @@
   return window_height_changed_p;
 }

+void
+warn_about_display_error (void)
+{
+  Lisp_Object warning[3];
+
+  warning[0] = intern ("display");
+  warning[1] = build_string ("Please check *Messages*");
+  warning[2] = intern (":error");
+  Vdelayed_warnings_list = Fcons (Flist (3, warning),
+                                  Vdelayed_warnings_list);
+}
+

 \f
 /***********************************************************************

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Thu, 26 Jan 2012 05:26:43 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, 10578@debbugs.gnu.org
> 
> all warnings of type `display' are assumed to be equivalent and only
> the most recent one is displayed; the rest are discarded.

Why not the first one?  More often than not, the others, if different,
will be the consequences of the first one, which is the root cause.
And if they are all identical, it doesn't matter which one you show ;-)

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Thu, Jan 26, 2012 at 06:43, Eli Zaretskii <eliz@gnu.org> wrote:

> Why not the first one?  More often than not, the others, if different,
> will be the consequences of the first one, which is the root cause.
> And if they are all identical, it doesn't matter which one you show ;-)

Just because delayed-warnings-list is ordered last-to-first and it's
easier to find the last one that the first one.

But this assumes that all such display warnings are produced by calls
to warn_about_display_error, and so they are all

  Error (display): Please check *Messages*

If we want to allow different kinds of display warnings, then the
thing to do is not to display the first one, but accumulate and
display them all (duplicates are no problem anyway because they are
collapsed by collapse-display-warnings, which runs before
show-display-errors-when-idle).

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Thu, 26 Jan 2012 13:27:30 +0100
> Cc: larsi@gnus.org, 10578@debbugs.gnu.org
> 
> On Thu, Jan 26, 2012 at 06:43, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > Why not the first one?  More often than not, the others, if different,
> > will be the consequences of the first one, which is the root cause.
> > And if they are all identical, it doesn't matter which one you show ;-)
> 
> Just because delayed-warnings-list is ordered last-to-first and it's
> easier to find the last one that the first one.
> 
> But this assumes that all such display warnings are produced by calls
> to warn_about_display_error, and so they are all
> 
>   Error (display): Please check *Messages*

I didn't understand that all the messages are identical, no matter
what triggered them.  If that's how we are going to implement them, it
indeed makes no difference which one you display.

To tell the truth, I don't like such vague warning, since the
reference to *Messages* is not specific enough to be useful, IMO.  It
is better to show some more specific text in the delayed warning
itself.

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Thu, Jan 26, 2012 at 14:45, Eli Zaretskii <eliz@gnu.org> wrote:

> To tell the truth, I don't like such vague warning, since the
> reference to *Messages* is not specific enough to be useful, IMO.  It
> is better to show some more specific text in the delayed warning
> itself.

That goes back to what I said in a previous message (that you didn't answer):

"If we want to warn with the real message for image_error, either we
duplicate the Fformat call in add_to_log, which seems a waste, or we
add some function xdisp.c:add_to_log_and_warn. Alternatively,
repurposing add_to_log to also (optionally) warn wouldn't be
difficult, as it is used only nine times in the sources."

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Thu, Jan 26, 2012 at 14:45, Eli Zaretskii <eliz@gnu.org> wrote:

> To tell the truth, I don't like such vague warning, since the
> reference to *Messages* is not specific enough to be useful, IMO.  It
> is better to show some more specific text in the delayed warning
> itself.

OK, next iteration.

The following patch shows all display warnings (errors, in fact),
after 5 seconds of idle time.

It's quite simple because I've assumed every call to add_to_log()
wants to warn, the TYPE (in warnings.el terminology) is always
`display', and the LEVEL is `:error'.

If not all such calls should warn, or the LEVEL should sometimes be
other than :error, the change is simple (just add a couple args to
add_to_log), though someone will have to decide what to do in each
current instance (as I said, it's not hard, as there are only nine or
so).

As for the TYPE, it's easy to change it in each case, but then
filtering gets a bit more complex for little gain.

    Juanma



=== modified file 'lisp/subr.el'
--- lisp/subr.el	2012-01-23 02:10:36 +0000
+++ lisp/subr.el	2012-01-26 17:00:50 +0000
@@ -1879,7 +1879,37 @@
         (push warning collapsed)))
     (setq delayed-warnings-list (nreverse collapsed))))

+(defconst display-errors-idle-time 5.0
+  "Interval of idle time before warning about display errors.")
+
+(defvar display-errors-pending nil
+  "Internal use only.")
+
+(defun show-display-errors-when-idle ()
+  "Warn about display errors when Emacs is idle.
+Only the most recent error (possibly collapsed) is shown,
+after `display-errors-idle-time' seconds of idle time;
+the rest are assumed to be identical and discarded.
+Used from `delayed-warnings-hook' (which see)."
+  (let ((errors nil)
+        (pending display-errors-pending))
+    (dolist (warning delayed-warnings-list)
+      (when (eq (car warning) 'display)
+        (push warning errors)))
+    (when errors
+      (setq delayed-warnings-list (assq-delete-all 'display
+                                                   delayed-warnings-list))
+      (setq display-errors-pending (nconc display-errors-pending errors))
+      (unless pending
+        (run-with-idle-timer display-errors-idle-time nil
+                             (lambda ()
+                               ;; Already sorted, no need to reverse
+                               (dolist (warning display-errors-pending)
+                                 (apply 'display-warning warning))
+                               (setq display-errors-pending nil)))))))
+
 (defvar delayed-warnings-hook '(collapse-delayed-warnings
+                                show-display-errors-when-idle
                                 display-delayed-warnings)
   "Normal hook run to process delayed warnings.
 Functions in this hook should access the `delayed-warnings-list'

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2012-01-19 07:21:25 +0000
+++ src/xdisp.c	2012-01-26 16:42:45 +0000
@@ -9069,6 +9069,12 @@
   message_dolog (buffer, len - 1, 1, 0);
   SAFE_FREE ();

+  args[0] = Qdisplay;
+  args[1] = msg;
+  args[2] = Qerror;
+  Vdelayed_warnings_list = Fcons (Flist (3, args),
+                                  Vdelayed_warnings_list);
+
   UNGCPRO;
 }

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Juanma Barranquero]

On Thu, Jan 26, 2012 at 18:22, Juanma Barranquero <lekktu@gmail.com> wrote:

> +(defun show-display-errors-when-idle ()
> +  "Warn about display errors when Emacs is idle.
> +Only the most recent error (possibly collapsed) is shown,
> +after `display-errors-idle-time' seconds of idle time;
> +the rest are assumed to be identical and discarded.
> +Used from `delayed-warnings-hook' (which see)."

The docstring should be fixed, of course :-)

    Juanma

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Juanma Barranquero <lekktu@gmail.com> writes:

> The following patch shows all display warnings (errors, in fact),
> after 5 seconds of idle time.

Did we forget about this one?  We didn't seem to apply it, at least...

> It's quite simple because I've assumed every call to add_to_log()
> wants to warn, the TYPE (in warnings.el terminology) is always
> `display', and the LEVEL is `:error'.
>
> If not all such calls should warn, or the LEVEL should sometimes be
> other than :error, the change is simple (just add a couple args to
> add_to_log), though someone will have to decide what to do in each
> current instance (as I said, it's not hard, as there are only nine or
> so).
>
> As for the TYPE, it's easy to change it in each case, but then
> filtering gets a bit more complex for little gain.
>
>     Juanma
>
> === modified file 'lisp/subr.el'
> --- lisp/subr.el	2012-01-23 02:10:36 +0000
> +++ lisp/subr.el	2012-01-26 17:00:50 +0000
> @@ -1879,7 +1879,37 @@
>          (push warning collapsed)))
>      (setq delayed-warnings-list (nreverse collapsed))))
>
> +(defconst display-errors-idle-time 5.0
> +  "Interval of idle time before warning about display errors.")
> +
> +(defvar display-errors-pending nil
> +  "Internal use only.")

(etc)

I think this looks like a good approach.  Any reason it wasn't applied?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>,  10578@debbugs.gnu.org
> Date: Mon, 08 Feb 2016 17:18:14 +1100
> 
> I think this looks like a good approach.  Any reason it wasn't applied?

The usual ones, sigh.

Please commit to emacs-25.  We should probably add something to the
docs and NEWS.

Thanks.

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  10578@debbugs.gnu.org
>> Date: Mon, 08 Feb 2016 17:18:14 +1100
>> 
>> I think this looks like a good approach.  Any reason it wasn't applied?
>
> The usual ones, sigh.
>
> Please commit to emacs-25.  We should probably add something to the
> docs and NEWS.
>
> Thanks.

The patch no longer applies.  In particular, this:

Where is this supposed to go?  The only place where we have text that
vaguely resembles this is in vadd_to_log, and that has to be the wrong
place...

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2012-01-19 07:21:25 +0000
+++ src/xdisp.c	2012-01-26 16:42:45 +0000
@@ -9069,6 +9069,12 @@
   message_dolog (buffer, len - 1, 1, 0);
   SAFE_FREE ();

+  args[0] = Qdisplay;
+  args[1] = msg;
+  args[2] = Qerror;
+  Vdelayed_warnings_list = Fcons (Flist (3, args),
+                                  Vdelayed_warnings_list);
+
   UNGCPRO;
 }


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Where is this supposed to go?  The only place where we have text that
> vaguely resembles this is in vadd_to_log, and that has to be the wrong
> place...

Oh, it is the right place.  Never mind.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Oops.  There's now

(defun collapse-delayed-warnings ()
  "Remove duplicates from `delayed-warnings-list'.
Collapse identical adjacent warnings into one (plus count).
Used from `delayed-warnings-hook' (which see)."
  (let ((count 1)
        collapsed warning)
    (while delayed-warnings-list
      (setq warning (pop delayed-warnings-list))
      (if (equal warning (car delayed-warnings-list))
          (setq count (1+ count))
        (when (> count 1)
          (setcdr warning (cons (format "%s [%d times]" (cadr warning) count)
                                (cddr warning)))
          (setq count 1))
        (push warning collapsed)))
    (setq delayed-warnings-list (nreverse collapsed))))

from 2013.  So I think this has already been fixed in a different way by
Stefan?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 10578@debbugs.gnu.org,  lekktu@gmail.com
> Date: Tue, 09 Feb 2016 11:23:47 +1100
> 
> Oops.  There's now
> 
> (defun collapse-delayed-warnings ()
>   "Remove duplicates from `delayed-warnings-list'.
> Collapse identical adjacent warnings into one (plus count).
> Used from `delayed-warnings-hook' (which see)."
>   (let ((count 1)
>         collapsed warning)
>     (while delayed-warnings-list
>       (setq warning (pop delayed-warnings-list))
>       (if (equal warning (car delayed-warnings-list))
>           (setq count (1+ count))
>         (when (> count 1)
>           (setcdr warning (cons (format "%s [%d times]" (cadr warning) count)
>                                 (cddr warning)))
>           (setq count 1))
>         (push warning collapsed)))
>     (setq delayed-warnings-list (nreverse collapsed))))
> 
> from 2013.  So I think this has already been fixed in a different way by
> Stefan?

If the recipe now does TRT, then yes.

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> 2) If I have both libpng12 and 14 installed, why is Emacs building
>> against 14 and then preferring 12 when running?
>
> Because Emacs on GNU/Linux doesn't use the kind of machinery it does
> on MS-Windows, whereby it will reject 12 if it was compiled against
> 14.  See w32-win.el:dynamic-library-alist, and in particular how it
> consults the variable libpng-version (which is set at compile time).

Right.  From what ldd said, it seemed like it was (dynamically) linked
against both lippng12 and 14, which seems odd to me.  Is that a bug?

Anyway, this is the first time I've seen something like this.  My home
machines usually grow very old and get a lot of different versions of
various libraries over the year, but compilation of stuff usually
doesn't fail just because of that.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Stefan Monnier]

>>> 2) If I have both libpng12 and 14 installed, why is Emacs building
>>> against 14 and then preferring 12 when running?
>> Because Emacs on GNU/Linux doesn't use the kind of machinery it does
>> on MS-Windows, whereby it will reject 12 if it was compiled against
>> 14.  See w32-win.el:dynamic-library-alist, and in particular how it
>> consults the variable libpng-version (which is set at compile time).
> Right.  From what ldd said, it seemed like it was (dynamically) linked
> against both lippng12 and 14, which seems odd to me.  Is that a bug?

Emacs probably links against one of the two, and then one of the other
libs used by Emacs (e.g., Gtk) link to the other one.

> Anyway, this is the first time I've seen something like this.  My home
> machines usually grow very old and get a lot of different versions of
> various libraries over the year, but compilation of stuff usually
> doesn't fail just because of that.

My machines also accumulate stuff like that and I rarely bump into the
problem, but it can happen.


        Stefan

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Achim Gratz]

Lars Ingebrigtsen <larsi@gnus.org> writes:
> Anyway, this is the first time I've seen something like this.  My home
> machines usually grow very old and get a lot of different versions of
> various libraries over the year, but compilation of stuff usually
> doesn't fail just because of that.

Anything you've posted looks exactly the same as the situation on my box
(which I've continually upgraded from either version 9.3 or 10.1 to 12.1
Tumbleweed).  So either something else was set differently in the
environment or the configure, I suppose.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

bug#10578: 24.0.92; No png images on OpenSUSE 12.1

[Achim Gratz]

Lars Ingebrigtsen <larsi@gnus.org> writes:
> I'm trying to compile Emacs 24 (current bzr) under OpenSUSE 12.1.
> Everything seems to work fine except inserting PNG images.
>
> If I do the following, I just get a blank square:
>
> (insert-image (create-image "/music/repository/Arto Lindsay/Prize/thumbnail.png"))
> t
>
> If I insert a gif or a jpeg, things work fine.  If I try to insert
> something that isn't an image at all, I get an error message.  But with
> pngs, I don't get any error messages, and I don't get an image, just
> that blank square.
>
> The png libraries seem to exist:
>
> larsi@linux-hvfx:~/src/emacs/trunk> ldd src/emacs | grep png
> 	libpng12.so.0 => /usr/lib/libpng12.so.0 (0xb7631000)
> 	libpng14.so.14 => /usr/lib/libpng14.so.14 (0xb656f000)
> larsi@linux-hvfx:~/src/emacs/trunk> ls -l /usr/lib/libpng12.so.0 /usr/lib/libpng14.so.14
> lrwxrwxrwx 1 root root 18 Dec  8 01:20 /usr/lib/libpng12.so.0 -> libpng12.so.0.46.0
> lrwxrwxrwx 1 root root 18 Nov 10 17:25 /usr/lib/libpng14.so.14 -> libpng14.so.14.8.0

I'm on Tumbleweed, but my system looks the same in that respect and PNG insertion
works a charm with Emacs24 compiled yesterday.  Check that

lrwxrwxrwx 1 root root     11 19. Nov 18:32 /usr/lib/libpng.so -> libpng12.so

it might point to libpng14.so on your system?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds