bug#10891: bug fix lisp/url/url-http.el

bug#10891: bug fix lisp/url/url-http.el

[Devon Sean McCullough]

(let ((url-gateway-unplugged t))
  (url-retrieve-synchronously "http://gnu.org"))

bombs
	Wrong type argument: processp, nil

should be
	Could not create connection to gnu.org:80

		Peace
			--Devon

PS: Here's the fix

--- url-http.el.~1~	2010-04-03 18:26:11.000000000 -0400
+++ url-http.el	2012-02-26 10:53:27.000000000 -0500
@@ -119,9 +120,7 @@
 	(url-http-debug "Reusing existing connection: %s:%d" host port)
       (url-http-debug "Contacting host: %s:%d" host port))
     (url-lazy-message "Contacting host: %s:%d" host port)
-    (url-http-mark-connection-as-busy
-     host port
-     (or found
+    (let ((conn (or found
          (let ((buf (generate-new-buffer " *url-http-temp*")))
            ;; `url-open-stream' needs a buffer in which to do things
            ;; like authentication.  But we use another buffer afterwards.
@@ -132,7 +131,9 @@
 		   ;; Drop the temp buffer link before killing the buffer.
 		   (set-process-buffer proc nil))
                  proc)
-             (kill-buffer buf)))))))
+                        (kill-buffer buf))))))
+      (and conn
+	   (url-http-mark-connection-as-busy host port conn)))))
 
 ;; Building an HTTP request
 (defun url-http-user-agent-string ()
 

bug#10891: bug fix lisp/url/url-http.el

[Chong Yidong]

Devon Sean McCullough <emacs-hacker2012@jovi.net> writes:

> (let ((url-gateway-unplugged t))
>   (url-retrieve-synchronously "http://gnu.org"))
>
> bombs
> 	Wrong type argument: processp, nil
>
> should be
> 	Could not create connection to gnu.org:80
>
> PS: Here's the fix

Thanks.  I've committed a slightly tweaked version of the fix to trunk.