From: Chong Yidong <cyd@gnu.org>
To: Andreas Politz <politza@fh-trier.de>
Cc: 6096@debbugs.gnu.org, 6095@debbugs.gnu.org
Subject: bug#6095: 24.0.50; code error in accept-change-group
Date: Mon, 23 Apr 2012 23:48:49 +0800 [thread overview]
Message-ID: <87aa2230v2.fsf@gnu.org> (raw)
In-Reply-To: <87hbmosqpf.fsf@fh-trier.de> (Andreas Politz's message of "Mon, 03 May 2010 21:58:04 +0200")
Andreas Politz <politza@fh-trier.de> writes:
> (defun accept-change-group (handle)
> "Finish a change group made with `prepare-change-group' (which see).
> This finishes the change group by accepting its changes as final."
> (dolist (elt handle)
> (with-current-buffer (car elt)
> (if (eq elt t)
> (setq buffer-undo-list t)))))
>
> I think this should be more like `(eq (cdr elt) t)', it should
> redeactivate undo. This test can not possibly succeed anyway.
Committed to trunk, thanks.
prev parent reply other threads:[~2012-04-23 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 19:58 bug#6095: 24.0.50; code error in accept-change-group Andreas Politz
2012-04-23 15:48 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa2230v2.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=6095@debbugs.gnu.org \
--cc=6096@debbugs.gnu.org \
--cc=politza@fh-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.