From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.devel Subject: Fix C-M-x on defcustoms Date: Wed, 08 Aug 2012 01:49:51 +0530 Message-ID: <87a9y6o3o8.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1344370800 12310 80.91.229.3 (7 Aug 2012 20:20:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 20:20:00 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 22:19:59 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyqFz-0006J7-9s for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 22:19:59 +0200 Original-Received: from localhost ([::1]:44415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyqFy-0005eI-HP for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 16:19:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyqFw-0005du-0N for emacs-devel@gnu.org; Tue, 07 Aug 2012 16:19:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyqFv-000099-3f for emacs-devel@gnu.org; Tue, 07 Aug 2012 16:19:55 -0400 Original-Received: from mail-pb0-f41.google.com ([209.85.160.41]:37442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyqFu-000093-T0 for emacs-devel@gnu.org; Tue, 07 Aug 2012 16:19:55 -0400 Original-Received: by pbbjt11 with SMTP id jt11so208462pbb.0 for ; Tue, 07 Aug 2012 13:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=MD6h9Gh0zVYVs8lvxlBnd5kOrQf0pdaUKiVtd6dB3v0=; b=L58DKLRZkyZ3UeHJIc1tmJNkpY1ObTQQd8cnpcpFns74e5CRzPvW+/Rv8JhDJKRHun yz1bU1iG6bSleigs/CMHs0HZ12tZhLCiHkqW8ypFDTtLnFuVj7LnRpAJC8MKXWG0iypm kvpywvjMYuXXK2b/+aZEGfyIGmc24xt4pOv1/yBbkr/45ulYN6KLEK+bXkFZizfhSChk tvWs//q1y7SzxbW2PgmQZT816AAqoUMFvspPs19gzNAAsCAKRlL50JFkerbfRnnBSOZ+ VAn1NVxftp1aqX+wc3pL/uGSWX6M7pGlymCHnZZhUy8XIbl1yIcBPaOSasoqtJMYfjy/ l2/Q== Original-Received: by 10.68.221.38 with SMTP id qb6mr30276337pbc.144.1344370793807; Tue, 07 Aug 2012 13:19:53 -0700 (PDT) Original-Received: from debian-6.05 ([101.63.165.112]) by mx.google.com with ESMTPS id qp6sm11774120pbc.55.2012.08.07.13.19.51 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Aug 2012 13:19:52 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152291 Archived-At: --=-=-= Content-Type: text/plain 1. M-x find-library RET vc-dir.el 2. C-s defcustom 3. C-M-x. Note the following backtrace. ,---- | Debugger entered--Lisp error: (invalid-function (\, (lambda nil nil))) | (\, (lambda nil nil))() | funcall((\, (lambda nil nil))) | eval((funcall (function (\, (lambda nil nil)))) t) | eval-defun-1((custom-declare-variable (quote vc-dir-mode-hook) (\` (funcall (function (\, (lambda nil nil))))) "Normal hook run by `vc-dir-mode'.\nSee `run-hooks'." :type (quote hook) :group (quote vc))) | eval-defun-2() | eval-defun(nil) | call-interactively(eval-defun nil nil) `---- It looks to me that it is an issue of orphaned "comma". 4. I am attaching a fix. Hopefully it is OK. ps: My next commit will come with all the ceremony. Until then ... -- --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-commit-108110.diff Content-Description: fix-commit-108110.diff === modified file 'lisp/custom.el' --- lisp/custom.el 2012-06-27 07:10:27 +0000 +++ lisp/custom.el 2012-08-07 19:45:37 +0000 @@ -337,7 +337,7 @@ ;; expression is checked by the byte-compiler, and that ;; lexical-binding is obeyed, so quote the expression with ;; `lambda' rather than with `quote'. - ``(funcall #',(lambda () ,standard)) + `(list 'funcall (lambda () ,standard)) `',standard) ,doc ,@args)) --=-=-=--