all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jambunathan K <kjambunathan@gmail.com>
To: emacs-devel@gnu.org
Subject: Fix C-M-x on defcustoms
Date: Wed, 08 Aug 2012 01:49:51 +0530	[thread overview]
Message-ID: <87a9y6o3o8.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]


1. M-x find-library RET vc-dir.el
2. C-s defcustom
3. C-M-x.  Note the following backtrace.

,----
| Debugger entered--Lisp error: (invalid-function (\, (lambda nil nil)))
|   (\, (lambda nil nil))()
|   funcall((\, (lambda nil nil)))
|   eval((funcall (function (\, (lambda nil nil)))) t)
|   eval-defun-1((custom-declare-variable (quote vc-dir-mode-hook) (\` (funcall (function (\, (lambda nil nil))))) "Normal hook run by `vc-dir-mode'.\nSee `run-hooks'." :type (quote hook) :group (quote vc)))
|   eval-defun-2()
|   eval-defun(nil)
|   call-interactively(eval-defun nil nil)
`----

It looks to me that it is an issue of orphaned "comma".

4. I am attaching a fix.

Hopefully it is OK.

ps: My next commit will come with all the ceremony.  Until then ...
-- 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-commit-108110.diff --]
[-- Type: text/x-diff, Size: 463 bytes --]

=== modified file 'lisp/custom.el'
--- lisp/custom.el	2012-06-27 07:10:27 +0000
+++ lisp/custom.el	2012-08-07 19:45:37 +0000
@@ -337,7 +337,7 @@
          ;; expression is checked by the byte-compiler, and that
          ;; lexical-binding is obeyed, so quote the expression with
          ;; `lambda' rather than with `quote'.
-         ``(funcall #',(lambda () ,standard))
+	 `(list 'funcall (lambda () ,standard))
        `',standard)
     ,doc
     ,@args))


             reply	other threads:[~2012-08-07 20:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 20:19 Jambunathan K [this message]
2012-08-07 21:54 ` Fix C-M-x on defcustoms Andreas Schwab
2012-08-07 22:03 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9y6o3o8.fsf@gmail.com \
    --to=kjambunathan@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.