From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 12321@debbugs.gnu.org
Subject: bug#12321: 24.2.50; `read-regexp' parameter PROMPT
Date: Thu, 20 Sep 2012 11:18:10 +0300 [thread overview]
Message-ID: <87a9wlbiwv.fsf@mail.jurta.org> (raw)
In-Reply-To: <C9602E347A804423B8D678C77401C44E@us.oracle.com> (Drew Adams's message of "Fri, 31 Aug 2012 15:38:45 -0700")
> First, there is the business of automatically handling `: ' for the
> PROMPT. I thought we had finally gotten away from this kind of thing.
> It just gives callers less control.
There are three contradicting requirements:
1. Maintain backward-compatibility for the PROMPT arg
in all existing calls to `read-regexp'.
2. Do not append automatically ": " to the end of PROMPT.
As bug#7567 demonstrates, more control for callers is necessary
to be able to use `read-regexp' in such specific contexts
as in `query-replace-read-from' that constructs prompt
according to the special format "%s (default %s -> %s): ".
3. The code should not be so "clever" in supporting
two these options above at the same time, as you said in
http://thread.gmane.org/gmane.emacs.devel/134852/focus=134854
But from these three options I see no better thing to do than
to allow `read-regexp' to be "clever" (like `read-buffer'):
=== modified file 'lisp/replace.el'
--- lisp/replace.el 2012-09-09 22:15:24 +0000
+++ lisp/replace.el 2012-09-20 08:15:20 +0000
@@ -597,10 +597,12 @@ (defun read-regexp (prompt &optional def
(history-add-new-input nil)
(input
(read-from-minibuffer
- (if default-value
- (format "%s (default %s): " prompt
- (query-replace-descr default-value))
- (format "%s: " prompt))
+ (if (string-match-p ":[ \t]*\\'" prompt)
+ prompt
+ (if default-value
+ (format "%s (default %s): " prompt
+ (query-replace-descr default-value))
+ (format "%s: " prompt)))
nil nil nil 'regexp-history defaults t)))
(if (equal input "")
(or default-value input)
next prev parent reply other threads:[~2012-09-20 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 22:38 bug#12321: 24.2.50; `read-regexp' parameter DEFAULT-VALUE and the calculated defaults Drew Adams
2012-09-01 12:04 ` Juri Linkov
2012-09-01 16:52 ` Drew Adams
2012-09-20 8:18 ` Juri Linkov [this message]
2012-09-20 12:46 ` bug#12321: 24.2.50; `read-regexp' parameter PROMPT Stefan Monnier
2012-09-20 21:59 ` Juri Linkov
2012-09-20 8:43 ` bug#12321: 24.2.50; `read-regexp' parameter DEFAULT-VALUE and the calculated defaults Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9wlbiwv.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=12321@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.