From: Michael Heerdegen <michael_heerdegen@web.de>
To: 12854@debbugs.gnu.org
Subject: bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented
Date: Sat, 10 Nov 2012 20:18:36 +0100 [thread overview]
Message-ID: <87a9upp8qb.fsf@web.de> (raw)
Hi,
The doc says:
> display-buffer-alist is a variable defined in `window.el'.
> [...]
>
> Alist of conditional actions for `display-buffer'.
> This is a list of elements (CONDITION . ACTION), where:
>
> CONDITION is either a regexp matching buffer names, or a function
> that takes a buffer and returns a boolean.
But the CONDITION is handled very differently by
`display-buffer-assq-regexp':
(defun display-buffer-assq-regexp (buffer-name alist)
"Retrieve ALIST entry corresponding to BUFFER-NAME."
(catch 'match
(dolist (entry alist)
(let ((key (car entry)))
(when (or (and (stringp key)
(string-match-p key buffer-name))
(and (symbolp key) (functionp key)
(funcall key buffer-name alist)))
(throw 'match (cdr entry)))))))
Obviously, two things are wrong here:
(1) If CONDITION is a function, it currently must be a symbol. I don't
see why lambda expressions should be forbidden. The user should not
need to use defun only to be able specify an argument.
(2) If CONDITION is a function, it takes _two_ arguments: a buffer
_name_ (not a buffer) _and_ an alist. That should be clarified in the
docstring.
Regards,
Michael.
In GNU Emacs 24.2.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2)
of 2012-11-01 on dex, modified by Debian
(emacs-snapshot package, version 2:20121101-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
System Description: Debian GNU/Linux testing (wheezy)
next reply other threads:[~2012-11-10 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 19:18 Michael Heerdegen [this message]
2012-11-10 19:42 ` bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented Michael Heerdegen
2012-11-16 15:33 ` martin rudalics
2012-11-18 1:02 ` Michael Heerdegen
2012-11-13 13:50 ` martin rudalics
2012-11-16 15:32 ` martin rudalics
2012-11-18 1:00 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9upp8qb.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=12854@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.