From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6137: [Yuriy Vostrikov] emacs, vc-git Date: Fri, 30 Nov 2012 15:43:38 +0800 Message-ID: <87a9tzsfh1.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354261448 9961 80.91.229.3 (30 Nov 2012 07:44:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Nov 2012 07:44:08 +0000 (UTC) Cc: Yuriy Vostrikov , 6137-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 30 08:44:19 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TeLGl-0007nM-H7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2012 08:44:19 +0100 Original-Received: from localhost ([::1]:49082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeLGa-0001uA-8R for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2012 02:44:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeLGX-0001t2-3a for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 02:44:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeLGR-0007PJ-Bo for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 02:44:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeLGR-0007PE-4h for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 02:43:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TeLIQ-0003a7-UI for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 02:46:02 -0500 Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2012 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 6137 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 6137@debbugs.gnu.org, cyd@gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 6137-done@debbugs.gnu.org id=D6137.135426155613751 (code D ref 6137); Fri, 30 Nov 2012 07:46:02 +0000 Original-Received: (at 6137-done) by debbugs.gnu.org; 30 Nov 2012 07:45:56 +0000 Original-Received: from localhost ([127.0.0.1]:46075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLIH-0003Zh-8C for submit@debbugs.gnu.org; Fri, 30 Nov 2012 02:45:54 -0500 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:50105) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLIE-0003ZV-9U for 6137-done@debbugs.gnu.org; Fri, 30 Nov 2012 02:45:51 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id hz11so158731pad.3 for <6137-done@debbugs.gnu.org>; Thu, 29 Nov 2012 23:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8zwIGnB/O4cy7kgBbJtGZ6efcari0i+0agVf+wDxhOo=; b=Azf9/qlZkGQtMZHquXSc5m7sb8wPsJmM7vesDD/sn0YbNMqBCAQ+7v2gvcBLY5gqzp F4M4cfVvPhYV5F+LCr1kvT2tyTFOGZAmStwpZav0GEvkL1KqXkSkOWxT6KR//a/NuY/O GBOrVXTTkUptihyERKq+//eRWv+V0vtJtJD5BVDNIunsg3IgcMDlznWhZotgmhqH0ovq 0vMHHVX5e+u2Uez/ZkMTC60PMUeHc5XkvqGAyXuk0Axu//tyChjVakfQICCNYgSIMTwU cGWmBFZ+2VxjhHpXq+4ne7sraZPIMnhNJOXww5Sw0JsXHRoOpxpDpzf6A6m/XwE2+640 /TLQ== Original-Received: by 10.66.73.102 with SMTP id k6mr1114091pav.22.1354261425445; Thu, 29 Nov 2012 23:43:45 -0800 (PST) Original-Received: from ulysses ([155.69.16.180]) by mx.google.com with ESMTPS id uh10sm2626290pbc.35.2012.11.29.23.43.41 (version=SSLv3 cipher=OTHER); Thu, 29 Nov 2012 23:43:44 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Fri, 07 May 2010 16:41:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67627 Stefan Monnier writes: > [ I do not use Git enough to be sure if his patch is the right way to > fix it. It does look OK, tho maybe the right (but harder) place to > fix it is in Tramp. Can someone take a look and install it? --Stef ] > > Hello. > You are last commiter of vc-git.el so i'm writing to you. > > It's probably a good idea to forcefully disable pager then calling git > command from vc-git.el. If buffer is tramp controlled then git will > be run on remote host by tramp magic. In this particular case git > stdout will be connected to pty instead of pipe and default git > behavior to call $PAGER in this case. Which is effectively makes > vc-git broken on tramp controlled buffers. Patch is attached. Since no one's done anything about this, and the fix looks OK, I've committed it to trunk.