From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#13197: 24.3.50; org-odt.el code that kills modified buffers Date: Sun, 16 Dec 2012 10:07:29 +0530 Message-ID: <87a9te629i.fsf@gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355632498 24547 80.91.229.3 (16 Dec 2012 04:34:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Dec 2012 04:34:58 +0000 (UTC) Cc: 13197@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 16 05:35:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tk5wW-0000HM-E2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Dec 2012 05:35:12 +0100 Original-Received: from localhost ([::1]:45174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk5wI-0005Y4-Sw for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Dec 2012 23:34:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk5wG-0005Xz-AX for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 23:34:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tk5wF-0002hU-8M for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 23:34:56 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk5wF-0002hQ-4o for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 23:34:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tk5xJ-0001FA-N1 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 23:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Dec 2012 04:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13197 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13197-submit@debbugs.gnu.org id=B13197.13556325374742 (code B ref 13197); Sun, 16 Dec 2012 04:36:01 +0000 Original-Received: (at 13197) by debbugs.gnu.org; 16 Dec 2012 04:35:37 +0000 Original-Received: from localhost ([127.0.0.1]:44565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tk5wu-0001EP-D3 for submit@debbugs.gnu.org; Sat, 15 Dec 2012 23:35:36 -0500 Original-Received: from mail-da0-f44.google.com ([209.85.210.44]:34877) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tk5wr-0001EH-V6 for 13197@debbugs.gnu.org; Sat, 15 Dec 2012 23:35:35 -0500 Original-Received: by mail-da0-f44.google.com with SMTP id z20so2140473dae.3 for <13197@debbugs.gnu.org>; Sat, 15 Dec 2012 20:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=kzZQ1ZjM6M4V9ylTyVH32CdzbLYa4hnut9fn1LmJ95s=; b=K3u6P4n4oP6uc5YKWu6M32M4d+o0HjD/eWLEiRzAFC5hKHGTvhsAMvGgVEIpyb+Pbz 3Oq/FTQOQjkSQEn1O2xFNfbMewekDiqdkAFYQahA4P5dAKF8FTekl/TM3A2IDrjgRFN7 GQ8Ot55AB1ubW7TTBHFyJDtcEo0eYmNOjqUBHXdI2AQB/ysuqs0n2SkE+3YM7yI2xNii dxNT54EIW4IddhaI/kK1tiqQI0Gk8PoUXIXnN2QZ8BWkSwJ2uVbDaxWMsNhU7BO53DIc ugPKR4FzO2Ur98dl+UgpOY6pzuf8z98PlfsT+bfhq0e4DNVfAwk7OX63snvYkIxlJHK5 1xyw== Original-Received: by 10.66.80.68 with SMTP id p4mr30211924pax.35.1355632465793; Sat, 15 Dec 2012 20:34:25 -0800 (PST) Original-Received: from debian-6.05 ([115.241.20.200]) by mx.google.com with ESMTPS id kl3sm5758147pbc.15.2012.12.15.20.34.22 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 15 Dec 2012 20:34:25 -0800 (PST) In-Reply-To: (Drew Adams's message of "Sat, 15 Dec 2012 14:35:45 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68593 Archived-At: "Drew Adams" writes: > I was grepping some source files to see how other code handles this kind > of thing, and I came across this in org-odt.el (in > `org-odt-cleanup-xml-buffers'): > > (mapc (lambda (file) > (let ((buf (find-file-noselect > (expand-file-name file org-odt-zip-dir) t))) > (when (buffer-name buf) > (set-buffer-modified-p nil) > (kill-buffer buf)))) > xml-files) > > I don't see how that can work properly, since `find-file-noselect' does > not make the visited-file buffer current, and `set-buffer-modified-p' > acts only on the current buffer. > > Am I missing something here, or is that a bug? It looks like a slip on my part. In all other places in org-odt.el, I do (with-current-buffer (find-file-noselect ) ) When an error is thrown during the export process, the buffer will be in modified but unsaved state. I forcibly mark the buffer as modified before killing it. Let me put in a fix in Org repo. Next merge will take care of this issue. --