From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r112183: Move forward-whitespace, forward-symbol, forward-same-syntax commands to subr.el. Use forward-symbol in supermode.el again. Date: Sat, 30 Mar 2013 08:10:38 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87a9plozpd.fsf@lifelogs.com> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364645480 12048 80.91.229.3 (30 Mar 2013 12:11:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Mar 2013 12:11:20 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 30 13:11:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ULudH-0004lx-Hw for ged-emacs-devel@m.gmane.org; Sat, 30 Mar 2013 13:11:39 +0100 Original-Received: from localhost ([::1]:50561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULuct-0004Ti-3N for ged-emacs-devel@m.gmane.org; Sat, 30 Mar 2013 08:11:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULuco-0004SU-9C for emacs-devel@gnu.org; Sat, 30 Mar 2013 08:11:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULucg-00085A-Gk for emacs-devel@gnu.org; Sat, 30 Mar 2013 08:11:10 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:60009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULucg-000854-AI for emacs-devel@gnu.org; Sat, 30 Mar 2013 08:11:02 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ULucz-0003vX-Bi for emacs-devel@gnu.org; Sat, 30 Mar 2013 13:11:21 +0100 Original-Received: from pool-72-93-31-86.bstnma.east.verizon.net ([72.93.31.86]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 30 Mar 2013 13:11:21 +0100 Original-Received: from tzz by pool-72-93-31-86.bstnma.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 30 Mar 2013 13:11:21 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pool-72-93-31-86.bstnma.east.verizon.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:Yh85E9J7SB8JJbTjUO2j+Z+Yf74= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158476 Archived-At: On Sat, 30 Mar 2013 13:04:30 +0800 Leo Liu wrote: LL> Why are you moving stuff into subr.el? Isn't it better move stuff out of LL> it? http://permalink.gmane.org/gmane.emacs.devel/158448 Stefan advised it for `forward-symbol' and after looking at `thingatpt.el', I agreed with him. The other two (`forward-same-syntax' and `forward-whitespace') were very similar so I followed the same logic: 1) simple, generally useful, small 2) use only basic Emacs commands and no commands from `thingatpt.el' 3) seem consistent with the rest of `subr.el' Perhaps we can have `motion.el' or something, but with the current layout `subr.el' seems the best place. Ted