From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Aaron Ecay <aaronecay@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix several byte-compile warnings in org-contrib files
Date: Mon, 01 Apr 2013 16:27:32 +0200 [thread overview]
Message-ID: <87a9pitjfv.fsf@gmail.com> (raw)
In-Reply-To: <1364783083-3175-1-git-send-email-aaronecay@gmail.com> (Aaron Ecay's message of "Sun, 31 Mar 2013 22:24:43 -0400")
Hello,
Thanks for your patch. Here are a few comments.
Aaron Ecay <aaronecay@gmail.com> writes:
> +(require 'cl-lib)
This is not an option since Org has to support Emacsen older than 24.3.
> - (add (remove-if (lambda (author) (string-match "others" author))
> - (remove-duplicates (apply #'append (col :authors))
> + (add (cl-remove-if (lambda (author) (string-match "others" author))
> + (cl-remove-duplicates (apply #'append (col :authors))
> :test #'string=)))
Here, we can use `org-remove-if' and `org-uniquify'.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-04-01 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 2:24 [PATCH] Fix several byte-compile warnings in org-contrib files Aaron Ecay
2013-04-01 14:27 ` Nicolas Goaziou [this message]
2013-04-03 11:13 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9pitjfv.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=aaronecay@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.