From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15754: 24.3.50; [PATCH] vc-ignore makes no sense Date: Sat, 07 Dec 2013 05:07:46 +0200 Message-ID: <87a9gdwe7x.fsf@yandex.ru> References: <87a9hrrl0p.fsf@hochschule-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386385696 13881 80.91.229.3 (7 Dec 2013 03:08:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Dec 2013 03:08:16 +0000 (UTC) Cc: 15754@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 07 04:08:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vp8Fe-0006x2-OD for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2013 04:08:18 +0100 Original-Received: from localhost ([::1]:34357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8Fe-0002Q4-11 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2013 22:08:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8FV-0002Pk-DS for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:08:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp8FP-0001je-7K for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:08:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8FP-0001ja-3y for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vp8FO-0000TA-6U for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2013 03:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15754-submit@debbugs.gnu.org id=B15754.13863856771791 (code B ref 15754); Sat, 07 Dec 2013 03:08:02 +0000 Original-Received: (at 15754) by debbugs.gnu.org; 7 Dec 2013 03:07:57 +0000 Original-Received: from localhost ([127.0.0.1]:35249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vp8FH-0000So-L9 for submit@debbugs.gnu.org; Fri, 06 Dec 2013 22:07:57 -0500 Original-Received: from mail-ea0-f169.google.com ([209.85.215.169]:60453) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vp8FF-0000Se-EP for 15754@debbugs.gnu.org; Fri, 06 Dec 2013 22:07:54 -0500 Original-Received: by mail-ea0-f169.google.com with SMTP id l9so611620eaj.14 for <15754@debbugs.gnu.org>; Fri, 06 Dec 2013 19:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=20spyjMN/SX6fcXIbZPERKwqGjK0pa+pjSs947DHGIo=; b=tNOp6Rwv97LDSBH9UyXKWWTxww8pRKXQ3D0EADv98TezE5lKGuCIaeZkxwuFfVWzXK BKC+37wtTkBrx/JvrJDDhCQc17s0Ftcg1W7th1b8Lc7ysj8TdL1RZER+aGMZ4FAvLnW5 U5aY/SvbFy/wCuFvLIpsi6ro+T7WAtKauun6ZWp8Bg9YT0T2SwfdqzSEoOfeGM36KAaW 4Q3XWtiAjGtJv6tRSw9DBgUT3Q+ZuwDaShMwwfMeZYoZKcvlbrQRp2l57WKJdOPenXNZ azB6KsJJBL0dNRss8nc/KaCIOTA+89wAE3Twa2MjMzRrG5nxzfFFiN8YQNpsXgcBbmQQ 8e6Q== X-Received: by 10.14.108.134 with SMTP id q6mr4856399eeg.96.1386385672611; Fri, 06 Dec 2013 19:07:52 -0800 (PST) Original-Received: from axl ([62.228.136.233]) by mx.google.com with ESMTPSA id g47sm1866907eeo.19.2013.12.06.19.07.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Dec 2013 19:07:49 -0800 (PST) In-Reply-To: <87a9hrrl0p.fsf@hochschule-trier.de> (Andreas Politz's message of "Wed, 30 Oct 2013 13:38:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81574 Archived-At: Hi Andreas, Andreas Politz writes: > There are two problems with this function. Or maybe three. :) The changes in the code and the functions signature look good to me, but I think the docstring actually became less accurate in places. > ! (defun vc-ignore (file &optional directory remove-p) > ! "Ignore or remove FILE under the VCS of DIRECTORY. "Remove file under the VCS" means something completely different. > ! Interactively, FILE is ignored, unless a prefix argument is > ! given, which queries for a FILE to remove from the list of > ! ignored files." Maybe "...in which case the function queries..."? And I think the usual form would be, "When called interactively, ignore FILE, unless ..., in which case prompt ...". You can grep Emacs source code for "When called interactively".