From: Bastien <bzg@gnu.org>
To: "François Pinard" <pinard@iro.umontreal.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-cycle-hook from org-mode hook
Date: Mon, 06 Jan 2014 17:47:22 +0100 [thread overview]
Message-ID: <87a9f96orp.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87wqidw6kl.fsf@iro.umontreal.ca> ("François Pinard"'s message of "Mon, 06 Jan 2014 09:03:38 -0500")
Hi François,
François Pinard <pinard@iro.umontreal.ca> writes:
> I noticed a recent change in Org mode behaviour, which I guess is
> related to a "git pull" of the org-mode project. This is so minor that
> it is hardly a problem for me, I only report it in case it would hint at
> some unwanted change that would have more consequences for others.
Thanks for reporting this.
The commit introducing the change must be this one:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=44acd000
> Opening an Org file in Emacs executes the hooks on org-mode-hooks.
> Previously, it also executed the hooks on org-cycle-hook, while now, I
> have the impression it does not anymore. The solution is easy for me, I
> merely run my own Org cycle hook function from my main Org mode hook.
The function `org-set-startup-visibility' is always called when you
find an Org file interactively. Previously, it used `org-cycle'
internally to set the visibility state. Now it uses `org-content`
and `org-overview' instead, so that C-u C-u TAB always work.
I think it makes sense to call org-cycle-hooks *only* when cycling
manually, so the current behavior makes sense IMO. Let me know if
you (or others) think otherwise.
--
Bastien
next prev parent reply other threads:[~2014-01-06 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 14:03 org-cycle-hook from org-mode hook François Pinard
2014-01-06 16:47 ` Bastien [this message]
2014-01-07 1:39 ` François Pinard
2014-01-07 9:16 ` Bastien
2014-01-09 16:20 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9f96orp.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=pinard@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.