From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#16541: 23.3; doc-view-open-text should grab place in current doc Date: Mon, 27 Jan 2014 11:25:09 +0100 Message-ID: <87a9ehhgca.fsf@gnu.org> References: <87ha8t2kws.fsf@chaos.shergill.su> <8738kc3lzm.fsf@chaos.shergill.su> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390818378 1481 80.91.229.3 (27 Jan 2014 10:26:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jan 2014 10:26:18 +0000 (UTC) Cc: 16541@debbugs.gnu.org To: Suhail Shergill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 27 11:26:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W7jOa-0003bC-5j for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jan 2014 11:26:24 +0100 Original-Received: from localhost ([::1]:58735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7jOW-0008UO-PW for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jan 2014 05:26:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7jOM-0008Jw-9B for bug-gnu-emacs@gnu.org; Mon, 27 Jan 2014 05:26:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7jOF-0005fp-0J for bug-gnu-emacs@gnu.org; Mon, 27 Jan 2014 05:26:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7jOE-0005fe-TK for bug-gnu-emacs@gnu.org; Mon, 27 Jan 2014 05:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7jOE-0001CJ-96 for bug-gnu-emacs@gnu.org; Mon, 27 Jan 2014 05:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jan 2014 10:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16541-submit@debbugs.gnu.org id=B16541.13908183234546 (code B ref 16541); Mon, 27 Jan 2014 10:26:02 +0000 Original-Received: (at 16541) by debbugs.gnu.org; 27 Jan 2014 10:25:23 +0000 Original-Received: from localhost ([127.0.0.1]:37383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7jNa-0001BF-Ih for submit@debbugs.gnu.org; Mon, 27 Jan 2014 05:25:22 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:55973) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7jNV-0001Az-1Z for 16541@debbugs.gnu.org; Mon, 27 Jan 2014 05:25:18 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 25EFB1A83CE; Mon, 27 Jan 2014 11:25:15 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bHxa76mOJbGC; Mon, 27 Jan 2014 11:25:14 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Original-Received: from thinkpad-t61 (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id AC9101A83CD; Mon, 27 Jan 2014 11:25:14 +0100 (CET) In-Reply-To: <8738kc3lzm.fsf@chaos.shergill.su> (Suhail Shergill's message of "Sat, 25 Jan 2014 02:10:47 +0000") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84103 Archived-At: Suhail Shergill writes: Hi! >> Currently doc-view has pretty much no idea about the format in use, >> so it doesn't know how to go from one page to another. > > except results shown by doc-view-search and doc-view-search-next-match > are associated with the correct page number as seen in docview mode > (even though it seems the search is conducted on the extracted > text). so, clearly that information is available to doc-view in some > sense. Suhail is correct. We could easily make C-c C-t switch to the current page using this patch: --8<---------------cut here---------------start------------->8--- === modified file 'lisp/doc-view.el' --- lisp/doc-view.el 2014-01-01 07:43:34 +0000 +++ lisp/doc-view.el 2014-01-27 10:22:11 +0000 @@ -1400,6 +1400,7 @@ (defun doc-view-open-text () "Open a buffer with the current doc's contents as text." (interactive) + (let ((page (doc-view-current-page))) (if doc-view--current-converter-processes (message "DocView: please wait till conversion finished.") (let ((txt (expand-file-name "doc.txt" (doc-view--current-cache-dir)))) @@ -1409,8 +1410,11 @@ (dir (file-name-directory buffer-file-name))) (with-current-buffer (find-file txt) (rename-buffer name) - (setq default-directory dir))) - (doc-view-doc->txt txt 'doc-view-open-text))))) + (setq default-directory dir) + ;; Jump to the current page + (goto-char (point-min)) + (search-forward " " nil t (1- page)))) + (doc-view-doc->txt txt 'doc-view-open-text)))))) ;;;;; Toggle between editing and viewing --8<---------------cut here---------------end--------------->8--- Should I install it? Bye, Tassilo