* bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
@ 2009-12-24 15:30 Drew Adams
2014-02-10 3:28 ` Lars Ingebrigtsen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Drew Adams @ 2009-12-24 15:30 UTC (permalink / raw)
To: bug-gnu-emacs
emacs -Q
In the definition of command `repeat':
(if (memq last-repeatable-command
'(exit-minibuffer
minibuffer-complete-and-exit
self-insert-and-exit))
This list of affected commands should not be hard-coded. If user code
uses different functions from `exit-minibuffer' and
`minibuffer-complete-and-exit', then users must redefine `repeat' to
accommodate this command difference. The `repeat' definition should
be more flexible than that.
This list of commands should be treated the same way we treat the list
of dangerous commands (`repeat-too-dangerous'): define a variable
whose value is the list of commands - do not hard-code the list.
In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
2009-12-24 15:30 bug#5264: 23.1; `repeat' should not hard-code the set of affected commands Drew Adams
@ 2014-02-10 3:28 ` Lars Ingebrigtsen
2016-04-27 21:17 ` Lars Ingebrigtsen
2021-07-18 14:39 ` Lars Ingebrigtsen
2 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10 3:28 UTC (permalink / raw)
To: Drew Adams; +Cc: 5264
"Drew Adams" <drew.adams@oracle.com> writes:
> In the definition of command `repeat':
>
> (if (memq last-repeatable-command
> '(exit-minibuffer
> minibuffer-complete-and-exit
> self-insert-and-exit))
[...]
> This list of commands should be treated the same way we treat the list
> of dangerous commands (`repeat-too-dangerous'): define a variable
> whose value is the list of commands - do not hard-code the list.
I agree, but probably not during the feature freeze.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
2009-12-24 15:30 bug#5264: 23.1; `repeat' should not hard-code the set of affected commands Drew Adams
2014-02-10 3:28 ` Lars Ingebrigtsen
@ 2016-04-27 21:17 ` Lars Ingebrigtsen
2021-07-18 14:39 ` Lars Ingebrigtsen
2 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-27 21:17 UTC (permalink / raw)
To: Drew Adams; +Cc: 5264
"Drew Adams" <drew.adams@oracle.com> writes:
> In the definition of command `repeat':
>
> (if (memq last-repeatable-command
> '(exit-minibuffer
> minibuffer-complete-and-exit
> self-insert-and-exit))
>
> This list of affected commands should not be hard-coded. If user code
> uses different functions from `exit-minibuffer' and
> `minibuffer-complete-and-exit', then users must redefine `repeat' to
> accommodate this command difference. The `repeat' definition should
> be more flexible than that.
>
> This list of commands should be treated the same way we treat the list
> of dangerous commands (`repeat-too-dangerous'): define a variable
> whose value is the list of commands - do not hard-code the list.
But what it is this does? If `last-repeatable-command' is any of these
commands, then we... repeat the first command in `command-history'
instead? What does that do, exactly?
(if (memq last-repeatable-command '(exit-minibuffer
minibuffer-complete-and-exit
self-insert-and-exit))
(let ((repeat-command (car command-history)))
(repeat-message "Repeating %S" repeat-command)
(eval repeat-command))
(if (null repeat-arg)
(repeat-message "Repeating command %S" last-repeatable-command)
(setq current-prefix-arg repeat-arg)
(repeat-message
"Repeating command %S %S" repeat-arg last-repeatable-command))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
2009-12-24 15:30 bug#5264: 23.1; `repeat' should not hard-code the set of affected commands Drew Adams
2014-02-10 3:28 ` Lars Ingebrigtsen
2016-04-27 21:17 ` Lars Ingebrigtsen
@ 2021-07-18 14:39 ` Lars Ingebrigtsen
2021-07-18 15:40 ` bug#5264: [External] : " Drew Adams
2 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-18 14:39 UTC (permalink / raw)
To: Drew Adams; +Cc: 5264
"Drew Adams" <drew.adams@oracle.com> writes:
> In the definition of command `repeat':
>
> (if (memq last-repeatable-command
> '(exit-minibuffer
> minibuffer-complete-and-exit
> self-insert-and-exit))
>
> This list of affected commands should not be hard-coded.
As far as I can tell, this list is gone from `repeat' in Emacs 28, so
I'm closing this bug report. If I missed something here, please respond
to the debbugs address and we'll reopen.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#5264: [External] : Re: bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
2021-07-18 14:39 ` Lars Ingebrigtsen
@ 2021-07-18 15:40 ` Drew Adams
2021-07-18 19:03 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2021-07-18 15:40 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 5264@debbugs.gnu.org
> > In the definition of command `repeat':
> >
> > (if (memq last-repeatable-command
> > '(exit-minibuffer
> > minibuffer-complete-and-exit
> > self-insert-and-exit))
> >
> > This list of affected commands should not be hard-coded.
>
> As far as I can tell, this list is gone from `repeat' in Emacs 28, so
> I'm closing this bug report. If I missed something here, please respond
> to the debbugs address and we'll reopen.
If you say so. The most recent snapshot (Windows) I have
of Emacs 28 (Jan 15, 2021) still has it:
(if (memq last-repeatable-command '(exit-minibuffer
minibuffer-complete-and-exit
self-insert-and-exit))
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#5264: [External] : Re: bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
2021-07-18 15:40 ` bug#5264: [External] : " Drew Adams
@ 2021-07-18 19:03 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2021-07-18 19:03 UTC (permalink / raw)
To: Drew Adams; +Cc: 5264, larsi
> From: Drew Adams <drew.adams@oracle.com>
> Date: Sun, 18 Jul 2021 15:40:07 +0000
> Cc: "5264@debbugs.gnu.org" <5264@debbugs.gnu.org>
>
> > As far as I can tell, this list is gone from `repeat' in Emacs 28, so
> > I'm closing this bug report. If I missed something here, please respond
> > to the debbugs address and we'll reopen.
>
> If you say so. The most recent snapshot (Windows) I have
> of Emacs 28 (Jan 15, 2021) still has it:
That's a 6-month old snapshot. And you can verify this is no longer
in Emacs by looking at the sources on Savannah, the URL was posted
many times in the past.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-18 19:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-24 15:30 bug#5264: 23.1; `repeat' should not hard-code the set of affected commands Drew Adams
2014-02-10 3:28 ` Lars Ingebrigtsen
2016-04-27 21:17 ` Lars Ingebrigtsen
2021-07-18 14:39 ` Lars Ingebrigtsen
2021-07-18 15:40 ` bug#5264: [External] : " Drew Adams
2021-07-18 19:03 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.