From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johan Claesson Newsgroups: gmane.emacs.bugs Subject: bug#12357: 24.2; list-load-path-shadow should ignore .dir-locals.el Date: Wed, 05 Mar 2014 08:09:20 +0100 Message-ID: <87a9d5qfz3.fsf@bredband.net> References: <87harcsi6n.fsf@bredband.net> <87ipbor4jg.fsf@bredband.net> <871ui1lrtk.fsf@bredband.net> <87y50yqmwd.fsf@gnu.org> <8761nwqmd5.fsf@bredband.net> <87r46kgrco.fsf@gnu.org> <87eh2hr41n.fsf@bredband.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394003416 24607 80.91.229.3 (5 Mar 2014 07:10:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Mar 2014 07:10:16 +0000 (UTC) To: 12357@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 05 08:10:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WL5y9-0003qU-QD for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 08:10:21 +0100 Original-Received: from localhost ([::1]:50443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL5y9-000183-8k for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 02:10:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL5xy-0000xT-R8 for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 02:10:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WL5xq-0003Ue-PM for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 02:10:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL5xq-0003UX-MU for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 02:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WL5xp-0001uq-TF for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 02:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Johan Claesson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Mar 2014 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12357-submit@debbugs.gnu.org id=B12357.13940033737317 (code B ref 12357); Wed, 05 Mar 2014 07:10:01 +0000 Original-Received: (at 12357) by debbugs.gnu.org; 5 Mar 2014 07:09:33 +0000 Original-Received: from localhost ([127.0.0.1]:51015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WL5xM-0001tv-KU for submit@debbugs.gnu.org; Wed, 05 Mar 2014 02:09:33 -0500 Original-Received: from smtprelay-h22.telenor.se ([195.54.99.197]:33336) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WL5xK-0001tm-2r for 12357@debbugs.gnu.org; Wed, 05 Mar 2014 02:09:31 -0500 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id EAC71C10D for <12357@debbugs.gnu.org>; Wed, 5 Mar 2014 08:09:28 +0100 (CET) X-SMTPAUTH-B2: [b157288] X-SENDER-IP: [85.224.212.166] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Atx/AErNFlNV4NSmPGdsb2JhbABagwaDRIUMuU0CAoESFwMBAQEBODWCJQEBAQECAVYoCwgDGAklDwEEDRgKLYdlAwkMAcZbDYZ2FxaMJoIcFoQiBJZPjlCIdjs X-IPAS-Result: Atx/AErNFlNV4NSmPGdsb2JhbABagwaDRIUMuU0CAoESFwMBAQEBODWCJQEBAQECAVYoCwgDGAklDwEEDRgKLYdlAwkMAcZbDYZ2FxaMJoIcFoQiBJZPjlCIdjs X-IronPort-AV: E=Sophos;i="4.97,591,1389740400"; d="scan'208";a="832672376" Original-Received: from c-a6d4e055.1542-1-64736c20.cust.bredbandsbolaget.se (HELO goblin) ([85.224.212.166]) by ipb1.telenor.se with ESMTP; 05 Mar 2014 08:09:17 +0100 In-Reply-To: (Leo Liu's message of "Wed, 05 Mar 2014 08:54:15 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86563 Archived-At: Well i would like the false positives to go away. That is the problem this attempts to fix. How about a defvar load-path-shadows-report-dir-locals instead? It would of course be true by default to preserve legacy behaviour. Regards, /Johan Leo Liu writes: > On 2014-03-05 06:29 +0800, Johan Claesson wrote: >> * emacs-lisp/shadows.el (load-path-shadows-find): Do not report >> .dir-locals.el files. >> (list-dir-locals-shadows): New command that reports shadows of >> .dir-locals.el in a way that make sense for that type of file. >> (dir-locals-shadows-find, dir-locals-shadows-find-1) >> (dir-locals-class-name, dir-locals-shadows-display): Auxiliary >> functions for list-dir-locals-shadows. > > I am not too sure what problems are solved by the change. > > In the case of list-load-path-shadows, it should print anything when in > doubt since false positives can be helpful. So it is not entirely wrong > to report .dir-locals.el. > > Use .dir-locals.el in a child directory to shadow parent directory isn't > uncommon practice. In future we might even make it capable of inheriting > settings in parent directory. So I am not even sure the use case of > listing .dir-locals files (defaulting to the load-path)?? > > Leo