all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Bastien <bzg@gnu.org>, emacs-devel@gnu.org
Subject: Re: Generating the ChangeLog files from the commit messages
Date: Wed, 19 Nov 2014 23:51:11 +0100	[thread overview]
Message-ID: <87a93mu7mo.fsf@engster.org> (raw)
In-Reply-To: <jwv389eg7fr.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 19 Nov 2014 17:21:51 -0500")

Stefan Monnier writes:
>> I'm all for it. My hope is that this is the first step in getting rid of
>> the Changelog format altogether, and switching to commit messages that
>> value content over form.
>
> I'm not sure what other format you have in mind which would have
> better content.

That's easy: prose. Just browse through projects like Git or Linux,
which enforce meaningful commit messages. I'm interested in the 'Why'
and 'How', not in the 'Where' and 'What'.

> FWIW, I think an ideal commit message should look like:
>
>     <location-summary> <change-summary>
>     <explanation-if-needed>

Unless it's a trivial change, it's always needed. Even when you have a
bug report, at least a copy&paste of the relevant bit should be there,
so you can quickly see the problem without having to look it up.

>     <bug-nb-if-applicable>

Sure.

>     <changelog-style details>

That's precisely what I'd drop. It's just a verbose diff. I'm not saying
it's completely useless (although it comes close), but it's not worth
the effort.

> In most cases, the explanation will be empty because the bug-nb provides
> the explanation or because the explanation can be placed in the code
> instead (a better choice, when applicable).

I disagree. Comments and commit logs are orthogonal. A comment helps you
understand how code works. A commit log describes why code was changed
(unless it's new, but that's less common).

-David



  reply	other threads:[~2014-11-19 22:51 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 14:39 Include necessary git tools in the Emacs distribution? Lars Magne Ingebrigtsen
2014-11-14 14:57 ` Tassilo Horn
2014-11-14 14:58 ` Eli Zaretskii
2014-11-14 16:13 ` Ulrich Mueller
2014-11-15 19:28   ` Lars Magne Ingebrigtsen
2014-11-15 20:04     ` Ulrich Mueller
2014-11-15 20:07       ` Lars Magne Ingebrigtsen
2014-11-15 20:34         ` Kelvin White
2014-11-15 20:35           ` Lars Magne Ingebrigtsen
2014-11-15 20:57             ` Ulrich Mueller
2014-11-15 21:45         ` Glenn Morris
2014-11-16  0:01         ` Lennart Borgman
2014-11-18  2:07   ` Rüdiger Sonderfeld
2014-11-18  2:15     ` Paul Eggert
2014-11-18 14:45       ` Generating the ChangeLog files from the commit messages (was: Include necessary git tools in the Emacs distribution?) Stefan Monnier
2014-11-18 14:59         ` Generating the ChangeLog files from the commit messages Ted Zlatanov
2014-11-18 16:22           ` Rüdiger Sonderfeld
2014-11-18 17:10         ` Glenn Morris
2014-11-18 17:40           ` Eli Zaretskii
2014-11-18 17:56             ` Paul Eggert
2014-11-18 20:32               ` Thien-Thi Nguyen
2014-11-18 21:12             ` Stefan Monnier
2014-11-18 22:05               ` Paul Eggert
2014-11-19 22:36                 ` Richard Stallman
2014-11-20  0:15                   ` Paul Eggert
2014-11-20  2:50                     ` Yuri Khan
2014-11-20  3:15                       ` Paul Eggert
2014-11-20  4:04                         ` Yuri Khan
2014-11-20 20:12                           ` Paul Eggert
2014-11-21  4:25                             ` Kelvin White
2014-11-21  7:57                               ` Paul Eggert
2014-11-19  9:03               ` Bastien
2014-11-19  9:11               ` Lars Magne Ingebrigtsen
2014-11-29 22:35               ` Paul Eggert
2014-11-30  0:23                 ` Jan D.
2014-11-30  9:12                 ` Jorgen Schaefer
2014-11-30 16:15                   ` Paul Eggert
2014-11-30 18:11                     ` Stefan Monnier
2014-11-30 18:23                       ` Eli Zaretskii
2014-11-30 18:30                         ` Lars Magne Ingebrigtsen
2014-11-30 20:32                           ` Eli Zaretskii
2014-11-30 21:50                           ` default large-file-warning-threshold (was: Generating the ChangeLog files ...) Paul Eggert
2014-11-30 23:19                             ` default large-file-warning-threshold Óscar Fuentes
2014-11-30 23:22                               ` Lars Magne Ingebrigtsen
2014-11-30 23:31                                 ` Óscar Fuentes
2014-12-01  5:46                                   ` Paul Eggert
2014-12-01 15:52                                     ` Eli Zaretskii
2014-12-01 18:13                                       ` Paul Eggert
2014-12-01 18:19                                         ` Lars Magne Ingebrigtsen
2014-12-01 18:24                                           ` Paul Eggert
2014-12-01 20:21                                           ` Ted Zlatanov
2014-12-01 20:32                                             ` Lars Magne Ingebrigtsen
2014-12-02  1:17                                               ` Ted Zlatanov
2014-12-02  5:07                                                 ` Lars Magne Ingebrigtsen
2014-12-01 19:00                                         ` Eli Zaretskii
2014-12-01 17:06                                 ` Achim Gratz
2014-12-01 17:56                                   ` Eli Zaretskii
2014-12-01 18:33                                     ` David Kastrup
2014-12-01 19:12                                       ` Eli Zaretskii
2014-12-01 19:15                                       ` Eli Zaretskii
2014-12-01 20:47                                   ` Rasmus
2014-12-01 19:15                             ` default large-file-warning-threshold (was: Generating the ChangeLog files ...) Richard Stallman
2014-12-02  5:15                             ` default large-file-warning-threshold Lars Magne Ingebrigtsen
2014-12-01  3:24                         ` Generating the ChangeLog files from the commit messages Stefan Monnier
2014-12-01  3:39                           ` Eli Zaretskii
2014-12-01  5:49                           ` Paul Eggert
2014-12-01  7:45                           ` H. Dieter Wilhelm
2014-11-30 16:35                 ` Lars Magne Ingebrigtsen
2014-11-19  9:02           ` Bastien
2014-11-19  9:38             ` Rasmus
2014-11-19 11:17               ` Bastien
2014-11-19 13:34                 ` Óscar Fuentes
2014-11-19 13:50                   ` Bastien
2014-11-19 16:29                 ` Yuri Khan
2014-11-19 16:43                   ` Eli Zaretskii
2014-11-19 16:52                     ` Yuri Khan
2014-11-19 18:49                       ` Eli Zaretskii
2014-11-20  2:54                         ` Yuri Khan
2014-11-20  9:38                           ` Bastien
2014-11-20  9:33                         ` Bastien
2014-11-20  9:31                   ` Bastien
2014-11-19 16:43             ` David Engster
2014-11-19 22:21               ` Stefan Monnier
2014-11-19 22:51                 ` David Engster [this message]
2014-11-21 10:03                   ` Eli Zaretskii
2014-11-21 16:19                     ` David Engster
2014-11-21 16:58                       ` Eli Zaretskii
2014-11-21 17:19                         ` Stefan Monnier
2014-11-21 17:21                         ` David Engster
2014-11-19 16:54     ` Include necessary git tools in the Emacs distribution? David Engster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a93mu7mo.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=bzg@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.