From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source... Date: Wed, 21 Jan 2015 17:38:36 +0100 Organization: Emacs Helm Message-ID: <87a91cxf5f.fsf@gmail.com> References: <87sif4txdv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421858426 26757 80.91.229.3 (21 Jan 2015 16:40:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2015 16:40:26 +0000 (UTC) To: 19645@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 21 17:40:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YDyKK-0001c5-Ja for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 17:40:20 +0100 Original-Received: from localhost ([::1]:49148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyKJ-0000Ce-Oi for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 11:40:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyKB-0000CT-Oh for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:40:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDyK3-0003Ed-8K for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:40:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyK3-0003EE-59 for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YDyK2-0005LL-MD for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:40:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87sif4txdv.fsf@gnu.org> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jan 2015 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142185834620467 (code B ref -1); Wed, 21 Jan 2015 16:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jan 2015 16:39:06 +0000 Original-Received: from localhost ([127.0.0.1]:52042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDyJ7-0005K2-Vd for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:39:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42985) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDyJ4-0005JS-43 for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:39:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDyIx-0002qC-AK for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:38:56 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:36011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyIx-0002q6-7n for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:38:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyIw-0008QG-4e for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:38:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDyIr-0002pX-RI for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:38:54 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:42170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyIr-0002pM-KX for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:38:49 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YDyIl-0000tB-UG for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 17:38:43 +0100 Original-Received: from 37.163.33.14 ([37.163.33.14]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Jan 2015 17:38:43 +0100 Original-Received: from thierry.volpiatto by 37.163.33.14 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Jan 2015 17:38:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 37.163.33.14 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) Cancel-Lock: sha1:/+rft0WD3CC+CYGxDKHR3IKLM5A= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98549 Archived-At: Stefan Monnier writes: >> helm-bbdb.el:22:1:Error: No next method for %S: helm--setup-source, >> nil, [eieio-class-tag--helm-type-file... > > It appears that you're calling helm--setup-source with an object of type > helm-type-file, but the only method that matches is a ":before" method, so > after running the before method, you get an error because there's > no primary. > > IIUC the error should be `cl-no-primary-method' instead of > `cl-no-next-method' (according to > http://www.cliki.net/Proposed%20ANSI%20Revisions%20and%20Clarifications). > > From what I can tell, the older EIEIO code just silently did nothing > in this case, treating the missing primary as a function that just > returns nil, but I think this is a mistake. > > I'm not sure how to preserve the compatibility with this mistake. > I'll see if I can come up with something, but in any case I think you > should fix Helm by making sure there is some primary method defined in > this case as well. `:before' and `:after' specify execution order (i.e., when this form is called). If neither of these symbols are present, the default priority is used (before `:after' and after `:before'); this default priority is represented in CLOS as `:primary'. I didn't specify :primary, because as I understand it is implicit if not mentionned, so IIUC I have to specify it now ? PS: Thanks to Cc me for thread related to helm so that I can fix issues. (Now should do as I have replied here) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997