all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <ivan@siamics.net>
To: 18175-done@debbugs.gnu.org
Subject: bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...)
Date: Fri, 23 Jan 2015 15:27:19 +0000	[thread overview]
Message-ID: <87a919o6ug.fsf@violet.siamics.net> (raw)
In-Reply-To: <jwviom46r1x.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Thu, 07 Aug 2014 15:29:03 -0400")

Version: 25.1

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

[…]

 >> However, I believe that the last two hunks of the one another
 >> variant of the diff (MIMEd) actually make the intent to return the
 >> reverse of the list returned by find-file-noselect /clearer,/ –
 >> although at the expense of adding one extra LoC in each case.

 > Agreed, and neither relies on the return value of `mapc', so those
 > two hunks are indeed good.  Please install them.

	Done; closing.

commit 3e824b05af3a75768a61001fad68e2340af810eb
CommitDate: 2015-01-17 19:33:08 +0000

    Avoid mapcar in two cases in files.el.
    
    * lisp/files.el (find-file-other-window, find-file-other-frame):
    Use mapc instead of mapcar.
    
    Fixes: debbugs:18175

-- 
FSF associate member #7257  np. Chemical Wedding – Bruce Dickinson  230E 334A





      reply	other threads:[~2015-01-23 15:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-02 21:55 bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...) Ivan Shmakov
2014-08-03  0:55 ` Drew Adams
2014-08-03  8:55   ` Ivan Shmakov
2014-08-03 16:32     ` Drew Adams
2014-08-03 18:25       ` Ivan Shmakov
2014-08-03 18:43         ` Drew Adams
2014-08-06 17:26 ` Stefan Monnier
2014-08-07 19:15   ` Ivan Shmakov
2014-08-07 19:29     ` Stefan Monnier
2015-01-23 15:27       ` Ivan Shmakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a919o6ug.fsf@violet.siamics.net \
    --to=ivan@siamics.net \
    --cc=18175-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.