From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Amann Newsgroups: gmane.emacs.devel Subject: Re: Fix bug with new firefox Date: Mon, 2 Mar 2015 20:58:11 +0000 Message-ID: <87a8zv5d7g.fsf@msstf091.ucc.ie> References: <87pp8r5nlw.fsf@msstf091.ucc.ie> <83k2yzqinb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1425329919 13858 80.91.229.3 (2 Mar 2015 20:58:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Mar 2015 20:58:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 02 21:58:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YSXQ0-0003I5-ID for ged-emacs-devel@m.gmane.org; Mon, 02 Mar 2015 21:58:24 +0100 Original-Received: from localhost ([::1]:59628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSXQ0-0003M2-1B for ged-emacs-devel@m.gmane.org; Mon, 02 Mar 2015 15:58:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSXPw-0003Lk-3X for emacs-devel@gnu.org; Mon, 02 Mar 2015 15:58:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSXPs-0001lc-2e for emacs-devel@gnu.org; Mon, 02 Mar 2015 15:58:20 -0500 Original-Received: from mail-db3on0090.outbound.protection.outlook.com ([157.55.234.90]:13442 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSXPr-0001lF-OT for emacs-devel@gnu.org; Mon, 02 Mar 2015 15:58:15 -0500 Original-Received: from AMSPR02CA0046.eurprd02.prod.outlook.com (10.242.225.174) by HE1PR02MB0649.eurprd02.prod.outlook.com (25.161.117.27) with Microsoft SMTP Server (TLS) id 15.1.99.14; Mon, 2 Mar 2015 20:58:13 +0000 Original-Received: from DB3FFO11FD016.protection.gbl (2a01:111:f400:7e04::103) by AMSPR02CA0046.outlook.office365.com (2a01:111:e400:8028::46) with Microsoft SMTP Server (TLS) id 15.1.99.14 via Frontend Transport; Mon, 2 Mar 2015 20:58:13 +0000 Original-Received: from mail4.ucc.ie (143.239.1.24) by DB3FFO11FD016.mail.protection.outlook.com (10.47.216.190) with Microsoft SMTP Server (TLS) id 15.1.99.6 via Frontend Transport; Mon, 2 Mar 2015 20:58:13 +0000 Original-Received: from msstf091.ucc.ie (msstf091.ucc.ie [143.239.76.91]) by mail4.ucc.ie (8.14.4/8.14.4) with ESMTP id t22KwDnp030243; Mon, 2 Mar 2015 20:58:13 GMT Original-Received: by msstf091.ucc.ie (Postfix, from userid 1000) id 39CAEA3CDA; Mon, 2 Mar 2015 20:58:11 +0000 (GMT) In-Reply-To: <83k2yzqinb.fsf@gnu.org> User-Agent: Notmuch/0.19 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-unknown-linux-gnu) X-EOPAttributedMessage: 0 Received-SPF: Pass (protection.outlook.com: domain of ucc.ie designates 143.239.1.24 as permitted sender) receiver=protection.outlook.com; client-ip=143.239.1.24; helo=mail4.ucc.ie; Authentication-Results: spf=pass (sender IP is 143.239.1.24) smtp.mailfrom=a.amann@ucc.ie; gnu.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:143.239.1.24; CTRY:IE; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(438002)(199003)(51704005)(189002)(16796002)(52956003)(48376002)(76176999)(54356999)(87936001)(50986999)(77156002)(62966003)(50466002)(86362001)(46386002)(19580405001)(36756003)(74482002)(83506001)(6806004)(110136001)(450100001)(106466001)(103686003)(92566002)(33646002)(2950100001)(19580395003)(47776003)(42186005)(46102003)(15975445007)(40036004)(90966001)(15409205003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR02MB0649; H:mail4.ucc.ie; FPR:; SPF:Pass; MLV:sfv; A:0; MX:1; LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR02MB0649; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006); SRVR:HE1PR02MB0649; BCL:0; PCL:0; RULEID:; SRVR:HE1PR02MB0649; X-Forefront-PRVS: 0503FF9A3E X-OriginatorOrg: ucc.ie X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2015 20:58:13.2919 (UTC) X-MS-Exchange-CrossTenant-Id: 46fe5ca5-866f-4e42-92e9-ed8786245545 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=46fe5ca5-866f-4e42-92e9-ed8786245545; Ip=[143.239.1.24] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR02MB0649 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 X-Received-From: 157.55.234.90 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183586 Archived-At: Eli Zaretskii writes: >> From: Andreas Amann >> Date: Mon, 2 Mar 2015 17:13:31 +0000 >> >> firefox 36.0 removed the "-remote" command line option, see >> https://www.mozilla.org/en-US/firefox/36.0/releasenotes/ >> >> Unfortunately this breaks "browse-url-firefox" which depends on it. To >> fix this, please apply the patch below. I also put the patch on github >> https://github.com/andram/emacs/commit/fd19dadba178f781117dfe524de834f337cbb1a6 >> not sure which is more convenient for devs, as I am not a regular >> contributor. >> >> Comment of patch: Patch now uses "--new-tab" and "--new-window" command >> line args, which are supported since a long time. This makes the >> sentinel redundant. It should in theory also work on MS-Windows, and >> even improve the situation in that links can now also be opened in a new >> tab if desired. However, I only tested the patch on linux. > > In which version of Firefox were these two options introduced? Not sure. I see them first mentioned in the release notes for Firefox 2.0 from 2006: http://website-archive.mozilla.org/www.mozilla.org/firefox_releasenotes/en-US/firefox/2.0/releasenotes/ At that point "-remote" was deprecated. However, back then they were spelled with one hyphen, i.e. "-new-tab" and "-new-window". I don't know, since when the double-hyphen version are working. To be on the save side, it is probably better to use single-hyphen "-new-tab" and "-new-window"?