all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: koppel@ece.lsu.edu, emacs-devel@gnu.org
Subject: Re: Clicks map to wrong line with line-spacing > nil.
Date: Sat, 01 Aug 2015 12:18:14 +0200	[thread overview]
Message-ID: <87a8ubpb15.fsf@gnu.org> (raw)
In-Reply-To: <83si83uy09.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Aug 2015 13:03:02 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> I can reproduce with emacs -Q and eb0f65b4.  Here's a recipe:
>
> Thanks.  I am still not sure what are we talking about.  I can almost
> say "not reproducible here", but see below.
>
> First, please try the latest master.

Ok, I'm on master now (e663cfec5a2dbf69d0f4360e1f8e05f81a037333).

>> 4. When I click on some word in lines 1-3, point is set on that word.
>> In later lines, point ends up on the previous line.  For ex., I click
>> on the "examples" in "Non-ASCII examples:" and point is set to the
>> beginning of the empty line before.  Clicking on "South" in "South
>> Asia:" puts point on "Middle" in "Middle/Near East:".
>
> Does point get set always on the _previous_ line?  Because the
> original report said something different, AFAIU:
>
>> try clicking on a line towards the bottom of the window. The
>> cursor moves to a point well above the mouse pointer.
>                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> To me, "well above" doesn't sound like the previous line, but several
> lines above that.  That I certainly cannot see.

With `line-spacing' of 50, it was always the previous line when clicking
in the two last thirds of the window (and the correct line in the 1st
third).  With `line-spacing' of 10, it were more lines too early
depending on how near the end of the window the click position was.

> Could it be that the problem depends on how many empty lines are
> between the window start and the location of the click?  If so, this
> might be one consequence of bug#21165, which I fixed a few minutes
> ago.

Yes, that seems to be it.  At least now with the current master HEAD,
point always jumps to exact the click position regardless of the
`line-spacing' value.

Thanks,
Tassilo



  reply	other threads:[~2015-08-01 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 20:29 Clicks map to wrong line with line-spacing > nil David Koppelman
2015-07-31 21:21 ` Eli Zaretskii
2015-07-31 21:29   ` David Koppelman
2015-08-01  7:19     ` Eli Zaretskii
2015-08-01  7:40       ` Tassilo Horn
2015-08-01 10:03         ` Eli Zaretskii
2015-08-01 10:18           ` Tassilo Horn [this message]
2015-08-01 12:21             ` Eli Zaretskii
2015-08-01 15:31               ` David Koppelman
2015-08-01 15:54                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8ubpb15.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=koppel@ece.lsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.