From: Nicolas Petton <nicolas@petton.fr>
To: Phillip Lord <phillip.lord@newcastle.ac.uk>, emacs-devel@gnu.org
Subject: Re: behaviour change in cl-subseq
Date: Thu, 06 Aug 2015 10:08:18 +0200 [thread overview]
Message-ID: <87a8u4x2j1.fsf@blueberry.home> (raw)
In-Reply-To: <87pp32orsy.fsf@newcastle.ac.uk>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Phillip Lord <phillip.lord@newcastle.ac.uk> writes:
> I've just had a bug report for pabbrev. The root cause is a change in
> the implementation of cl-subseq.
>
> In Emacs 24:
>
> (cl-subseq '() 10 10) ;; nil
>
> While in Emacs 25
>
> In Emacs 25 `cl-subseq' has been redefined in terms of seq-subseq.
>
> (seq-subseq '() 10 10) ;; errors
> (cl-subseq '() 10 10) ;; errors
>
> Which is a reasonably substantial change in the interface of cl-subseq.
> The actual (exceptional) behaviour of cl-subseq is not documented, so
> it's reasonable, but perhaps not sensible. It's easy to fix in pabbrev
> (and anywhere) in a way which does not require me to probe for Emacs
> versions.
>
> I offer no opinions, just wanted to check whether this was intended.
Hi,
The change was apparently intended, and was done in commit
253d44bd27b7d90b614b6b968a3b125eeb0a48f2
Cheers,
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2015-08-06 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 12:14 behaviour change in cl-subseq Phillip Lord
2015-08-06 0:10 ` Leo Liu
2015-08-06 6:11 ` Tassilo Horn
2015-08-06 9:34 ` Phillip Lord
2015-08-06 9:48 ` Leo Liu
2015-08-07 14:00 ` Phillip Lord
2015-08-07 14:26 ` Nicolas Petton
2015-08-07 15:51 ` Phillip Lord
2015-08-07 16:08 ` Nicolas Petton
2015-08-07 21:23 ` Phillip Lord
2015-08-08 19:56 ` Nicolas Petton
2015-08-20 20:50 ` Phillip Lord
2015-08-21 0:02 ` Artur Malabarba
2015-08-06 8:08 ` Nicolas Petton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8u4x2j1.fsf@blueberry.home \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@newcastle.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.