From: Michael Albinus <michael.albinus@gmx.de>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 21241@debbugs.gnu.org
Subject: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached
Date: Fri, 21 Aug 2015 11:46:28 +0200 [thread overview]
Message-ID: <87a8tlm0sr.fsf@gmx.de> (raw)
In-Reply-To: <878u9gly4p.fsf@gnu.org> (Tassilo Horn's message of "Wed, 12 Aug 2015 10:16:54 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> So I've tried the following:
>
> diff --git a/src/gfilenotify.c b/src/gfilenotify.c
> index 08713a8..2ad2110 100644
> --- a/src/gfilenotify.c
> +++ b/src/gfilenotify.c
> @@ -172,8 +172,9 @@ will be reported only in case of the 'moved' event. */)
> gflags |= G_FILE_MONITOR_SEND_MOVED;
>
> /* Enable watch. */
> - monitor = g_file_monitor (gfile, gflags, NULL, NULL);
> - if (! monitor)
> + GError *err = NULL;
> + monitor = g_file_monitor (gfile, gflags, NULL, &err);
> + if (! monitor || err != NULL)
> xsignal2 (Qfile_notify_error, build_string ("Cannot watch file"), file);
>
> Lisp_Object watch_descriptor = make_pointer_integer (monitor);
For the records, I've committed a modified version of this patch. It
returns the error message from g_file_monitor, if present.
Best regards, Michael.
prev parent reply other threads:[~2015-08-21 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 8:16 bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached Tassilo Horn
[not found] ` <handler.21241.B.14393674365819.ack@debbugs.gnu.org>
2015-08-12 8:34 ` Tassilo Horn
2015-08-12 12:47 ` Eli Zaretskii
2015-08-12 13:27 ` Tassilo Horn
2015-08-12 14:16 ` Eli Zaretskii
2015-08-12 19:18 ` Michael Albinus
2015-08-15 1:27 ` Paul Eggert
2015-08-18 14:33 ` Tassilo Horn
2015-08-18 17:09 ` Paul Eggert
2015-08-21 9:46 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8tlm0sr.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=21241@debbugs.gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.