From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.devel Subject: Re: Debugging emacs memory management Date: Mon, 05 Oct 2015 03:02:16 -0700 Message-ID: <87a8rx1vmf.fsf@secretsauce.net> References: <87zj8l3r32.fsf@secretsauce.net> <87vbbbxz2e.fsf@secretsauce.net> <55F998C8.4080203@cs.ucla.edu> <87vbb492ea.fsf@secretsauce.net> <83twqonub8.fsf@gnu.org> <87oagw885o.fsf@secretsauce.net> <837fnknlbm.fsf@gnu.org> <834mionkdg.fsf@gnu.org> <87fv1p232b.fsf@secretsauce.net> <83wpv1zr4q.fsf@gnu.org> <87egh9205z.fsf@secretsauce.net> <83r3l9zowx.fsf@gnu.org> <87d1wt1xe0.fsf@secretsauce.net> <87bncd1w88.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444039366 29769 80.91.229.3 (5 Oct 2015 10:02:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2015 10:02:46 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 05 12:02:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zj2bE-0002e0-DT for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 12:02:28 +0200 Original-Received: from localhost ([::1]:45111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj2bD-0007R8-Sq for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 06:02:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj2bA-0007Qu-E5 for emacs-devel@gnu.org; Mon, 05 Oct 2015 06:02:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj2b4-0006P1-QF for emacs-devel@gnu.org; Mon, 05 Oct 2015 06:02:24 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj2b4-0006Ot-Mb for emacs-devel@gnu.org; Mon, 05 Oct 2015 06:02:18 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2AF9820CEF for ; Mon, 5 Oct 2015 06:02:18 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 05 Oct 2015 06:02:18 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=1t5p2 wJqfh+GMsL/QSQD1abdJZ8=; b=isZnmHpHPMkkumBIkX+tBAv+9mJd/DvprJycp yQeu3ktkHdsGTTMEaHOHVtBDFBNakBA8z834FvtaNFD6vLXxjV8qXNuXyJG2xQ4u fzK7M4mvSxZJO9vfkj43m+C959Ha6tVftzo9AqdcL0YlrsU9e0iQoT+oiyjckPpj QgsobI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=1t5p2wJqfh+GMsL/QSQD1abdJZ8=; b=j6Rdl M2v0SV1Rxm+6UhD/B+ndtyNdWsF4YVyR3zSrwIynr+xoDzackuwl2uUOaYZGBMeK sN7YB4miwqmHrqnK2Um1XI1uxkdrA4zIQxOvxRI5L0NWxw1zXmKjsBFhHd1i1us8 HCsl0r/KiOa4PS8qp7J54nrqjwDH1BZn0XC6ck= X-Sasl-enc: JHsvH/H9FCB/PSySQupV5Y8axbgCWkPSQLxlOnXYNut6 1444039337 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id CDACEC0001D; Mon, 5 Oct 2015 06:02:17 -0400 (EDT) Original-Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Zj2b2-0000ki-Kr; Mon, 05 Oct 2015 03:02:16 -0700 In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190933 Archived-At: Andreas Schwab writes: > Dima Kogan writes: > >> diff --git a/src/font.c b/src/font.c >> index 8e06532..ca872d0 100644 >> --- a/src/font.c >> +++ b/src/font.c >> @@ -3981,7 +3981,15 @@ copy_font_spec (Lisp_Object font) >> pcdr = spec->props + FONT_EXTRA_INDEX; >> for (tail = AREF (font, FONT_EXTRA_INDEX); CONSP (tail); tail = XCDR (tail)) >> if (!EQ (XCAR (XCAR (tail)), QCfont_entity)) >> - *pcdr = Fcons (XCAR (tail), Qnil), pcdr = xcdr_addr (*pcdr); >> + { >> + if (CONSP (XCAR (tail))) > > This better be always true, otherwise XCAR (XCAR (tail)) would be a bug. It isn't. Without that check I was getting every time. *ERROR*: Wrong type argument: listp, "monospace-10" Surprised me too, and I haven't checked to see what was happening there. I will look... tomorrow. It's bed time.