From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22250@debbugs.gnu.org, larsi@gnus.org
Subject: bug#22250: 25.0.50; Eww fails to break RTL paragraph
Date: Tue, 29 Dec 2015 21:55:24 +0100 [thread overview]
Message-ID: <87a8ot9dqb.fsf@justinian.turtle-trading.net> (raw)
In-Reply-To: <83io3hdwwg.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 29 Dec 2015 18:47:43 +0200")
Benjamin Riefenstahl writes:
>> I have uploaded this now to my private webserver as
>> <https://odoacer.turtle-trading.net/abc-abc-abc-abc-abc-abc-abc-abc-abc-abc-abc-abc-abc-abc-test.html>.
>> This URL reproduces the problem for me after "G RET".
>
Eli Zaretskii writes:
> Not for me, it doesn't. I tried "G RET" quite a few times, it always
> displays correctly.
You're right it works now, since
03dbfb9 * (eww-setup-buffer): Restore left-to-right defaults
Yesterday I had still been on the earlier f9d87dd. Oh the joy of moving
targets ;-)
But that's ok, so this case and my script text case are solved in
practice. I'm still concerned about the behaviour of vertical-motion in
this, though.
On practical level, there is still the matter of paragraphs using
diacritics. Do you have an idea how to fix those?
For your other questions:
>> In the bad case, for the first line, everything looks the same,
>> vertical-motion gets called with the same parameter, but when it returns
>> point is at 161. Which is not good.
>
> What does window-hscroll return in each of these two cases?
I checked that again with the commit before 03dbfb9. I inserted a call
to `message' to make sure I got the right window. It's 0 for the good
case, 67 for the bad case. Basically the same as it->w->hscroll on the
C level.
>> In the good case, it->w->hscroll is 0, in the bad case it->w->hscroll is
>> 68.
>> Experimentation tells me that the interpretation of window-hscroll
>> (whether it refers to the left or the right margin) depends on
>> bidi-paragraph-direction, is that right?
>
> Yes and no. It depends on what you mean by "interpretation".
I was starting from the doc on window.hscroll in window.h and the
docstring for window-hscroll. The docstring says
Return the number of columns by which WINDOW is scrolled from left
margin.
But with bidi-paragraph-direction set to RTL window-hscroll works with
respect to the right margin. I just verified again.
>> Note that at the point when vertical-motion is called and gives
>> different answers, bidi-paragraph-direction is always right-to-left, so
>> it looks like some window parameter that depends on
>> bidi-paragraph-direction is cached somewhere?
>
> The value of bidi-paragraph-direction shouldn't matter when
> bidi-display-reordering is nil (I've just went through the entire code
> and didn't see any place where we use that value when
> bidi-display-reordering is nil). But just in case I missed something,
> try bindings bidi-paragraph-direction to nil or left-to-right where I
> bind bidi-display-reordering, and see if that helps.
With both variables set in shr-insert-document, I consistently get a
seemingly correctly wrapped but left justified (LTR) paragraph,
regardless which version I use, I tried in 5049827 (the one before
03dbfb9) and with the current 88e2de2. This is with the above mentioned
URL.
> P.S. I'm going to commit my patch, as it definitely improves things
> and is clearly TRT to do (and I'm tired of stashing it ;-).
Got it.
next prev parent reply other threads:[~2015-12-29 20:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 19:11 bug#22250: 25.0.50; Eww fails to break RTL paragraph Benjamin Riefenstahl
2015-12-27 19:27 ` Eli Zaretskii
2015-12-27 23:09 ` Benjamin Riefenstahl
2015-12-28 3:32 ` Eli Zaretskii
2015-12-28 16:40 ` Benjamin Riefenstahl
2015-12-28 17:12 ` Eli Zaretskii
2015-12-28 17:49 ` Eli Zaretskii
2015-12-28 18:15 ` Benjamin Riefenstahl
2015-12-28 18:30 ` Eli Zaretskii
2015-12-28 21:23 ` Benjamin Riefenstahl
2015-12-29 16:47 ` Eli Zaretskii
2015-12-29 20:55 ` Benjamin Riefenstahl [this message]
2015-12-29 21:03 ` Eli Zaretskii
2015-12-29 22:33 ` Benjamin Riefenstahl
2015-12-30 17:04 ` Eli Zaretskii
2015-12-30 20:22 ` Benjamin Riefenstahl
2015-12-30 20:30 ` Benjamin Riefenstahl
2015-12-31 15:26 ` Eli Zaretskii
2015-12-31 18:10 ` Benjamin Riefenstahl
2015-12-31 18:23 ` Eli Zaretskii
2015-12-30 17:15 ` Eli Zaretskii
2015-12-28 16:46 ` Lars Ingebrigtsen
2015-12-28 19:07 ` Benjamin Riefenstahl
2015-12-28 19:29 ` Eli Zaretskii
2015-12-27 19:30 ` Lars Ingebrigtsen
2015-12-27 19:38 ` Eli Zaretskii
2015-12-27 19:45 ` Eli Zaretskii
2015-12-27 19:49 ` Lars Ingebrigtsen
2015-12-27 20:22 ` Eli Zaretskii
2015-12-27 20:28 ` Eli Zaretskii
2015-12-27 21:00 ` Eli Zaretskii
2015-12-27 21:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8ot9dqb.fsf@justinian.turtle-trading.net \
--to=b.riefenstahl@turtle-trading.net \
--cc=22250@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.