From mboxrd@z Thu Jan 1 00:00:00 1970 From: phillip.lord@russet.org.uk (Phillip Lord) Subject: bug#22399: org-mode fontification Date: Mon, 18 Jan 2016 18:05:25 +0000 Message-ID: <87a8o2zrtm.fsf__1737.09371961213$1454275257$gmane$org@russet.org.uk> References: <87oacjng36.fsf@russet.org.uk> <87ziw36khb.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLEBq-00039G-Ep for emacs-orgmode@gnu.org; Mon, 18 Jan 2016 13:06:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLEBm-0003C7-Cu for emacs-orgmode@gnu.org; Mon, 18 Jan 2016 13:06:06 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87ziw36khb.fsf@gmx.us> (rasmus@gmx.us's message of "Mon, 18 Jan 2016 15:16:48 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: 22399@debbugs.gnu.org Rasmus writes: > Hi Phillip, > > Thanks for your report. > > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> On emacs-25 ox-html, line 1847, org-html-fontify-code does this... >> >> (setq code (with-temp-buffer >> ;; Switch to language-specific mode. >> (funcall lang-mode) >> (insert code) >> ;; Fontify buffer. >> (org-font-lock-ensure) >> >> >> But `org-font-lock-ensure' is defined like so.... >> >> (defalias 'org-font-lock-ensure >> (if (fboundp 'org-font-lock-ensure) >> #'font-lock-ensure >> (lambda (_beg _end) (font-lock-fontify-buffer)))) >> >> >> which takes two args, causing crashes when exporting to code to HTML. > > This is fixed in the most recent stable version of Org, i.e. 8.3.3=EF=BB= =BF=C2=B9 , > which, I guess, will be part of if Emacs 25.2 or 26.1 (whichever comes > first and allow new features). It=E2=80=99s also fixed in 8.2.10=EF=BB= =BF=C2=B2. I guess > Emacs-25 should switch v8.2.10. [Honestly, when v8.3 couldn=E2=80=99t be= merged I > did not cross my mind to upgrade to v8.2.10]. In case v8.2.10 it too > radical, a "local fix" must be applied to the version of Org in emacs.git. Well, the fix on emacs-25 appears to be trivial i.e. (org-font-lock-ensure (point-min) (point-max)) But I don't know what the protocol is for org-mode as it's upstream. AFAICT, this is a regression from emacs-24.5, so it would be a shame if the bug gets into 25.1. Let me know if you want me to do anything! Phil