From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#22399: org-mode fontification Date: Mon, 18 Jan 2016 18:05:25 +0000 Message-ID: <87a8o2zrtm.fsf@russet.org.uk> References: <87oacjng36.fsf@russet.org.uk> <87ziw36khb.fsf@gmx.us> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1453140384 5195 80.91.229.3 (18 Jan 2016 18:06:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jan 2016 18:06:24 +0000 (UTC) Cc: 22399@debbugs.gnu.org To: Rasmus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 18 19:06:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aLEBz-00041y-PY for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 19:06:15 +0100 Original-Received: from localhost ([::1]:33078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLEBz-0003Ej-1F for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 13:06:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLEBs-0003BC-CT for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 13:06:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLEBr-0003G1-Fj for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 13:06:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLEBm-0003Bu-AY; Mon, 18 Jan 2016 13:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aLEBm-0004vv-5z; Mon, 18 Jan 2016 13:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Mon, 18 Jan 2016 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22399 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 22399-submit@debbugs.gnu.org id=B22399.145314032818912 (code B ref 22399); Mon, 18 Jan 2016 18:06:02 +0000 Original-Received: (at 22399) by debbugs.gnu.org; 18 Jan 2016 18:05:28 +0000 Original-Received: from localhost ([127.0.0.1]:53170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLEBE-0004uy-28 for submit@debbugs.gnu.org; Mon, 18 Jan 2016 13:05:28 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:55734) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLEBC-0004uf-4D for 22399@debbugs.gnu.org; Mon, 18 Jan 2016 13:05:26 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1aLEBB-0003gK-E6; Mon, 18 Jan 2016 18:05:25 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1aLEBB-0003GF-5n; Mon, 18 Jan 2016 18:05:25 +0000 In-Reply-To: <87ziw36khb.fsf@gmx.us> (rasmus@gmx.us's message of "Mon, 18 Jan 2016 15:16:48 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111718 Archived-At: Rasmus writes: > Hi Phillip, > > Thanks for your report. > > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> On emacs-25 ox-html, line 1847, org-html-fontify-code does this... >> >> (setq code (with-temp-buffer >> ;; Switch to language-specific mode. >> (funcall lang-mode) >> (insert code) >> ;; Fontify buffer. >> (org-font-lock-ensure) >> >> >> But `org-font-lock-ensure' is defined like so.... >> >> (defalias 'org-font-lock-ensure >> (if (fboundp 'org-font-lock-ensure) >> #'font-lock-ensure >> (lambda (_beg _end) (font-lock-fontify-buffer)))) >> >> >> which takes two args, causing crashes when exporting to code to HTML. > > This is fixed in the most recent stable version of Org, i.e. 8.3.3=EF=BB= =BF=C2=B9 , > which, I guess, will be part of if Emacs 25.2 or 26.1 (whichever comes > first and allow new features). It=E2=80=99s also fixed in 8.2.10=EF=BB= =BF=C2=B2. I guess > Emacs-25 should switch v8.2.10. [Honestly, when v8.3 couldn=E2=80=99t be= merged I > did not cross my mind to upgrade to v8.2.10]. In case v8.2.10 it too > radical, a "local fix" must be applied to the version of Org in emacs.git. Well, the fix on emacs-25 appears to be trivial i.e. (org-font-lock-ensure (point-min) (point-max)) But I don't know what the protocol is for org-mode as it's upstream. AFAICT, this is a regression from emacs-24.5, so it would be a shame if the bug gets into 25.1. Let me know if you want me to do anything! Phil