Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

[Michael Strey]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

When starting an org-drill session, I expect the answer to the question
to be hidden.  Since my last update, I see question and answer at the
same time.

I tracked the problem down to commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258.

In function org-drill-hide-subheadings-if the following call of org-map-entries is
used:

(org-map-entries
       (lambda ()
         (when (and (not (outline-invisible-p))
                    (> (org-current-level) drill-entry-level))
           (when (or (/= (org-current-level) (1+ drill-entry-level))
                        (funcall test))
             (hide-subtree))
           (push (point) drill-sections)))
       "" 'tree)


Emacs  : GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6)
 of 2015-09-10 on foutrelis
Package: Org-mode version 8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)
-- 
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey

Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

[Nicolas Goaziou]

Hello,

Michael Strey <mstrey@strey.biz> writes:

> When starting an org-drill session, I expect the answer to the question
> to be hidden.  Since my last update, I see question and answer at the
> same time.
>
> I tracked the problem down to commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258.
>
> In function org-drill-hide-subheadings-if the following call of org-map-entries is
> used:
>
> (org-map-entries
>        (lambda ()
>          (when (and (not (outline-invisible-p))
>                     (> (org-current-level) drill-entry-level))
>            (when (or (/= (org-current-level) (1+ drill-entry-level))
>                         (funcall test))
>              (hide-subtree))
>            (push (point) drill-sections)))
>        "" 'tree)

Could you provide an ECM?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

[Michael Strey]

On Di, 2016-02-02 at 17:58, Nicolas Goaziou wrote:

[...]

> Could you provide an ECM?

Well, yes, maybe, but I would like to avoid this effort.

After reverting the mentioned commit, org-drill is working like expected again
and the function call:

(org-make-tags-matcher "")

evaluates to:

("" lambda (todo tags-list level)
  (and (member todo org-not-done-keywords) (and t t)))

In HEAD it evaluates to:

("" lambda (todo tags-list level)
  (and (member todo org-not-done-keywords) nil))

Hope that helps.  If not, I will go and make my homework with the ECM.

Best regards
-- 
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey

Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

[Nicolas Goaziou]

Hello,

Michael Strey <mstrey@strey.biz> writes:

> After reverting the mentioned commit, org-drill is working like expected again
> and the function call:
>
> (org-make-tags-matcher "")
>
> evaluates to:
>
> ("" lambda (todo tags-list level)
>   (and (member todo org-not-done-keywords) (and t t)))
>
> In HEAD it evaluates to:
>
> ("" lambda (todo tags-list level)
>   (and (member todo org-not-done-keywords) nil))
>
Hopefully fixed in master. Could you confirm it?

Thank you.


Regards,

-- 
Nicolas Goaziou

Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]

[Michael Strey]

On Di, 2016-02-02 at 22:59, Nicolas Goaziou wrote:
> Hello,
>
> Michael Strey <mstrey@strey.biz> writes:
>
>> After reverting the mentioned commit, org-drill is working like expected again
>> and the function call:
>>
>> (org-make-tags-matcher "")
>>
>> evaluates to:
>>
>> ("" lambda (todo tags-list level)
>>   (and (member todo org-not-done-keywords) (and t t)))
>>
>> In HEAD it evaluates to:
>>
>> ("" lambda (todo tags-list level)
>>   (and (member todo org-not-done-keywords) nil))
>>
> Hopefully fixed in master. Could you confirm it?

Yes, org-drill works again.  Thank you!

Best regards
-- 
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey