From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jess Balint Newsgroups: gmane.emacs.bugs Subject: bug#22737: 25.1; Finalizer should be optional in dynamic modules Date: Thu, 18 Feb 2016 15:52:55 -0600 Message-ID: <87a8mxsn2g.fsf@oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455832705 653 80.91.229.3 (18 Feb 2016 21:58:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Feb 2016 21:58:25 +0000 (UTC) To: 22737@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 18 22:58:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWWaR-00042c-PW for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Feb 2016 22:58:11 +0100 Original-Received: from localhost ([::1]:46002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWaR-0000qF-7v for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Feb 2016 16:58:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWaN-0000pw-Nq for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:58:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWWaI-0007D2-Op for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:58:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWaI-0007Cy-LE for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aWWaI-0006bl-GR for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jess Balint Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2016 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22737 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145583263725336 (code B ref -1); Thu, 18 Feb 2016 21:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2016 21:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:33293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWWZZ-0006aZ-Dw for submit@debbugs.gnu.org; Thu, 18 Feb 2016 16:57:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56261) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWWTX-0006R6-DN for submit@debbugs.gnu.org; Thu, 18 Feb 2016 16:51:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWWTR-0005yv-C8 for submit@debbugs.gnu.org; Thu, 18 Feb 2016 16:50:58 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:55582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWTR-0005ym-96 for submit@debbugs.gnu.org; Thu, 18 Feb 2016 16:50:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWTQ-0005tn-CS for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:50:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWWTL-0005to-CL for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:50:56 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:43556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWTL-0005te-4i for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2016 16:50:51 -0500 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1ILonnR005919 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Feb 2016 21:50:50 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u1ILomh8003950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 18 Feb 2016 21:50:49 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1ILomv4002880 for ; Thu, 18 Feb 2016 21:50:48 GMT Original-Received: from rukh (/10.154.117.160) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Feb 2016 13:50:48 -0800 User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Thu, 18 Feb 2016 16:57:16 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113260 Archived-At: Dynamic modules are really cool so far, but I think finalizers should not be mandatory for user pointers (alloc.c): #ifdef HAVE_MODULES else if (mblk->markers[i].m.u_any.type == Lisp_Misc_User_Ptr) { struct Lisp_User_Ptr *uptr = &mblk->markers[i].m.u_user_ptr; uptr->finalizer (uptr->p); <----- should NULL-check first } #endif c.f. https://github.com/emacs-mirror/emacs/blob/master/src/alloc.c#L6893 Thanks! Jess