From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#23186: closed (Re: bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match) Date: Sun, 03 Apr 2016 17:55:29 +0200 Message-ID: <87a8laoff2.fsf@gmx.de> References: <831t6nsyzy.fsf@gnu.org> <87a8lbpzbv.fsf@gmx.de> <83d1q6rbdu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459699000 28717 80.91.229.3 (3 Apr 2016 15:56:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Apr 2016 15:56:40 +0000 (UTC) Cc: ja2038@gmail.com, 23186@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 03 17:56:28 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amkO3-0001Ln-Rj for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 17:56:28 +0200 Original-Received: from localhost ([::1]:54013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkO3-00074O-Bv for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 11:56:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkNh-0006cw-PS for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 11:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amkNe-0004J9-Jd for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 11:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkNe-0004J5-GK for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 11:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amkNd-0008Iw-Qd for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 11:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Apr 2016 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23186-submit@debbugs.gnu.org id=B23186.145969893931894 (code B ref 23186); Sun, 03 Apr 2016 15:56:01 +0000 Original-Received: (at 23186) by debbugs.gnu.org; 3 Apr 2016 15:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:50108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amkNG-0008IM-Pw for submit@debbugs.gnu.org; Sun, 03 Apr 2016 11:55:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:57602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amkNF-0008I9-49 for 23186@debbugs.gnu.org; Sun, 03 Apr 2016 11:55:37 -0400 Original-Received: from detlef.gmx.de ([87.146.46.179]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MLfLH-1an1cY3t9H-000qKh; Sun, 03 Apr 2016 17:55:30 +0200 In-Reply-To: <83d1q6rbdu.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Apr 2016 17:54:21 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:Bc1QotPussH9stIogq2xT9L9QE93KQlK9q6ioeOkPdCQHSpSQgU QmMiFOywACq4Jsy6R2+CTiamAX9ym7Kb8Wykc7IQA0WucJUeB6rfZadR9vcdcYM7FxTv5mT oFfMLJTjaEJh+7gz2l9bacCuP/5RWR/wWOaDu9AsL9NrcuFcK0u+eJ9R/NG8D7t4Cw0lcz/ xUr3H/fTziv3u/2r0mvig== X-UI-Out-Filterresults: notjunk:1;V01:K0:I2TioDenq0s=:p5m/i/Wv4h195PoaED7+KZ 1r7w0d/9Z1PJ7VS+7OvgxDVegorJ28FrJFqUadCRZbrjxsJQrRSsFB7VQ28OWt8e9DQ0n+Zk8 P15JKBuRw9OxsLMAbHrP48Nfzvm3kGxRrnsdaUvtK+dUoqmEM0OPiBqwiJ+si9nAkPbSdEkIr 02h1xu86OSvt0tQTOvs7u4AjHERqi2X2C/8Z06Q3lpRWKpHCFisSlGEt3U2N/+CE2ghQ+Jxjb YLPEnd1hY5cCD1KtHnPh0ePcXNuoUi/tTJAA07HOLEBJu5Iw5l3d1RmTQ2D1DiSkjz1+HmVtW mE5lxx0cwlZNn2Gzi4IwfhE5YfsJ1yLvNuhO0VQrDZaMLMp3p0tsNVUmvZ98nOzRjo6l8Etz1 8i6ZXpYV2s4880Lp6+S9SlN+lZueYsRL8K7oDzICymlyCzVV0ETCXTozsBa27XqrP/I/Nb2ax 3ZyvVjLsCMh2kLEfGvjexwjFMZfEI4WI2w3me6RXzTBHBlcmBqy0ITreqya9M6QahAXntFdpW 1AyzQzAA/UH79nkjJN/cxhVoxl35p1FkX2jKZQWcJg4fhryUZ8FOICmQqeVNUOh/8qJtHTjkI YDUN5FWwL+USVEQgEIe7D2M8PPvMMPkUWCdLiOOdN9YYkBlMnobIX6aaAfnyiFLnQT89HnzKU +XbNq28KlBS2Hswu3ak8pftrH4Y4bhwGnmzjc9IGDmH/AiArY/3GxJkA3ucv15/mCmAadMZx9 48Zq0Vto8WzfXtdc0GaG7W5+l6FdZtOZzMvZp8Ope2FH70dU18qW5jgiLe1y0KnlGprIYVOP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115936 Archived-At: Eli Zaretskii writes: Hi Eli, >> Make a proposal about a config option which could be used >> instead of the COMSPEC env which doesn't exist in your environment. Make >> a proposal how to avoid calling cmd.exe at all, it seems not be >> mandatory, I believe. Propose something else what is possible. > > Let me try ;-) > > Can you (Michael) explain why does Tramp need this variable, and also > why it needs the companion tramp-encoding-command-switch? Why not > just use shell-file-name and shell-command-switch? Or, if you must > look deeper, why not call w32-shell-name or w32-shell-dos-semantics? > I think these already do what you need tramp-encoding-shell for, but > maybe I'm missing something. Well, this is set this way for decades. I don't remember the datails; likely it was used also for other cases than just local encoding/ decoding. And don't forget, Tramp has carried a lot of compat code, back to Emacs 21 and XEmacs. Maybe it was not possible to trust on `w32-shell-name'. This compat code has been removed recently. So it is applicable indeed, to use `w32-shell-name'. I've committed a patch to master, doing this. I don't know, whether the setting for `tramp-encoding-command-switch' is OK, 'tho. As usual, I cannot test it for w32. Let's see, whether we get reports :-) > If I'm right, and Tramp doesn't really need to calculate the shell's > name separately from the rest of Emacs, then this problem will cease > to be a "Tramp problem". That won't solve the larger problems the OP > would have in Emacs, but at least Tramp will no longer be accused ;-) Agreed. This fits perfectly to the Tramp cleanup, I have applied back in January. Best regards, Michael.