From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ja2038@gmail.com, 23186@debbugs.gnu.org
Subject: bug#23186: closed (Re: bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match)
Date: Sun, 03 Apr 2016 17:55:29 +0200 [thread overview]
Message-ID: <87a8laoff2.fsf@gmx.de> (raw)
In-Reply-To: <83d1q6rbdu.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Apr 2016 17:54:21 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eli,
>> Make a proposal about a config option which could be used
>> instead of the COMSPEC env which doesn't exist in your environment. Make
>> a proposal how to avoid calling cmd.exe at all, it seems not be
>> mandatory, I believe. Propose something else what is possible.
>
> Let me try ;-)
>
> Can you (Michael) explain why does Tramp need this variable, and also
> why it needs the companion tramp-encoding-command-switch? Why not
> just use shell-file-name and shell-command-switch? Or, if you must
> look deeper, why not call w32-shell-name or w32-shell-dos-semantics?
> I think these already do what you need tramp-encoding-shell for, but
> maybe I'm missing something.
Well, this is set this way for decades. I don't remember the datails;
likely it was used also for other cases than just local encoding/
decoding. And don't forget, Tramp has carried a lot of compat code, back
to Emacs 21 and XEmacs. Maybe it was not possible to trust on `w32-shell-name'.
This compat code has been removed recently. So it is applicable indeed,
to use `w32-shell-name'. I've committed a patch to master, doing this. I
don't know, whether the setting for `tramp-encoding-command-switch' is
OK, 'tho.
As usual, I cannot test it for w32. Let's see, whether we get reports :-)
> If I'm right, and Tramp doesn't really need to calculate the shell's
> name separately from the rest of Emacs, then this problem will cease
> to be a "Tramp problem". That won't solve the larger problems the OP
> would have in Emacs, but at least Tramp will no longer be accused ;-)
Agreed. This fits perfectly to the Tramp cleanup, I have applied back in
January.
Best regards, Michael.
next prev parent reply other threads:[~2016-04-03 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 16:06 bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match Jerry Asher
2016-04-02 16:44 ` Eli Zaretskii
2016-04-02 17:26 ` Eli Zaretskii
2016-04-02 19:37 ` Michael Albinus
2016-04-02 20:03 ` Eli Zaretskii
2016-04-02 20:21 ` Jerry Asher
2016-04-02 20:29 ` Eli Zaretskii
2016-04-03 7:05 ` Michael Albinus
[not found] ` <handler.23186.D23186.145961804117806.notifdone@debbugs.gnu.org>
2016-04-02 17:32 ` bug#23186: closed (Re: bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match) Jerry Asher
2016-04-02 17:37 ` Jerry Asher
2016-04-02 17:50 ` Jerry Asher
2016-04-02 19:47 ` Michael Albinus
2016-04-02 20:02 ` Eli Zaretskii
2016-04-02 20:19 ` Jerry Asher
2016-04-02 20:33 ` Eli Zaretskii
2016-04-02 20:11 ` bug#23186: closed (Re: " Jerry Asher
2016-04-02 20:28 ` Eli Zaretskii
2016-04-03 7:15 ` Michael Albinus
2016-04-02 21:35 ` John Wiegley
2016-04-03 14:54 ` Eli Zaretskii
2016-04-03 15:55 ` Michael Albinus [this message]
2016-04-03 16:17 ` Eli Zaretskii
2016-04-03 16:49 ` Michael Albinus
2016-04-03 14:51 ` bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8laoff2.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=23186@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ja2038@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.