From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex =?UTF-8?Q?Benn=C3=A9e?= Newsgroups: gmane.emacs.bugs Subject: bug#23917: [O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Tue, 19 Jul 2016 18:05:37 +0100 Message-ID: <87a8hdmuce.fsf@linaro.org> References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1468948290 1550 80.91.229.3 (19 Jul 2016 17:11:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 17:11:30 +0000 (UTC) Cc: 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com, Stefan Monnier , nljlistbox2@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 19:11:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPYYB-0005Uv-Sa for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 19:11:20 +0200 Original-Received: from localhost ([::1]:57350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYYA-00084m-Ue for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 13:11:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYT8-0003RK-UF for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 13:06:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPYT4-0005fd-Mx for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 13:06:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYT4-0005fT-J8; Tue, 19 Jul 2016 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPYT4-0005jr-5D; Tue, 19 Jul 2016 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex =?UTF-8?Q?Benn=C3=A9e?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 19 Jul 2016 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146894794522035 (code B ref 23917); Tue, 19 Jul 2016 17:06:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 19 Jul 2016 17:05:45 +0000 Original-Received: from localhost ([127.0.0.1]:57530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPYSn-0005jL-5W for submit@debbugs.gnu.org; Tue, 19 Jul 2016 13:05:45 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:35834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPYSk-0005j5-JR for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 13:05:43 -0400 Original-Received: by mail-wm0-f51.google.com with SMTP id f65so145800385wmi.0 for <23917@debbugs.gnu.org>; Tue, 19 Jul 2016 10:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=biMJ2VWZSwMYPFIpfHsuzTm3b+68RUrGgjZrX++ts0c=; b=SdXuy/BGUEqT2MljMdDP4G3QMMznNj6aN9TpR84RWFmFqMcgMaDu3yFDf7CQFCnlO4 aiu2wdJHBj1NPb8AWixqOVnR02dK3sGYcal/iLhENuM/eFl2dvNtJPP1DfyabInc3Rc/ ZQPJd9JzbGFfykqyKGCBEAIbjHWk0a1IMf4w0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=biMJ2VWZSwMYPFIpfHsuzTm3b+68RUrGgjZrX++ts0c=; b=d8DCfDaMo7kOekUAwc6pSsbEv1wXgIPyslbp1h5gLpOgV2lsgskD+RSJetquUdBlCD PQ2uUCWZxbZ3DFKGi0549qH8CkXy7c9Lu/BdG+eGtCsixVJWSYdY5stM4gK8zHZkUrjC 7hTot3QxJesb0DA827hnfj4FPrKdeTgpXZ2w8vrMzHEuOfALSXId+XVkOGfrq/NuF7JF BOJ3l5uaK7AmtuNvwv/c++AIZ6RLWRmGW5SrrKEN9W2/OCAbnOmuzOpYCGQourinhuk/ YvPVkd3A6PPo8AheRxD9ve0EldBaGPCKVMgNktriFVKTVrqaGE/6zrDvAbscC8z4wAwF 8CQg== X-Gm-Message-State: ALyK8tJHeqLvr+DMM07xMGtRlSUmydgV/oIsDK08lLip3Z09bUjqjKmOeEgtHIQgE+9PbJGB X-Received: by 10.28.54.229 with SMTP id y98mr5371238wmh.96.1468947936897; Tue, 19 Jul 2016 10:05:36 -0700 (PDT) Original-Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id x62sm24411016wmf.13.2016.07.19.10.05.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 10:05:35 -0700 (PDT) Original-Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id 6484C3E0404; Tue, 19 Jul 2016 18:05:37 +0100 (BST) User-agent: mu4e 0.9.17; emacs 25.0.95.10 In-reply-to: <834m7l1u8u.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121269 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: rpluim@gmail.com, 23917@debbugs.gnu.org, alex.bennee@linaro.org, jwiegley@gmail.com, nljlistbox2@gmail.com >> Date: Tue, 19 Jul 2016 12:03:51 -0400 >> >> I guess the next best thing is: >> - copy search_regs.start and search_regs.end before calling replace_range. >> - use that copy when adjusting the match data. >> Or equivalently, use save-match-data. IOW go back to your original patch. >> Duh! > > Do we care that using save-match-data in every call to replace-match > might mean a performance hit? If it will, then this will again punish > most of the users for the benefit of those few who (1) have > buffer-modification hooks, and (2) those hooks call save-match-data. I care unless there is an easy way to identify which buffer modification hooks are responsible so I can take steps as a user to mitigate the problems. -- Alex Bennée