From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Newsgroups: gmane.emacs.bugs Subject: bug#24620: Forward: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters Date: Fri, 28 Oct 2016 11:22:41 +0200 Message-ID: <87a8dog74u.wl-domenechjosel@gmail.com> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1477646732 13058 195.159.176.226 (28 Oct 2016 09:25:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Oct 2016 09:25:32 +0000 (UTC) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) To: 24620@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 28 11:25:28 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c03PW-0001Sh-L0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Oct 2016 11:25:14 +0200 Original-Received: from localhost ([::1]:47752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c03PZ-0000I8-41 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Oct 2016 05:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c03NS-0007DD-US for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 05:23:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c03NP-00070m-PB for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 05:23:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c03NP-00070a-LV for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 05:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c03NO-0001kA-8h for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 05:23:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2016 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24620-submit@debbugs.gnu.org id=B24620.14776465706671 (code B ref 24620); Fri, 28 Oct 2016 09:23:02 +0000 Original-Received: (at 24620) by debbugs.gnu.org; 28 Oct 2016 09:22:50 +0000 Original-Received: from localhost ([127.0.0.1]:33176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c03NB-0001jX-T9 for submit@debbugs.gnu.org; Fri, 28 Oct 2016 05:22:50 -0400 Original-Received: from mail-wm0-f68.google.com ([74.125.82.68]:33345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c03NB-0001jL-5Y for 24620@debbugs.gnu.org; Fri, 28 Oct 2016 05:22:49 -0400 Original-Received: by mail-wm0-f68.google.com with SMTP id m83so6532567wmc.0 for <24620@debbugs.gnu.org>; Fri, 28 Oct 2016 02:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:subject:references :user-agent:in-reply-to:references:disposition-notification-to :return-receipt-to:mime-version; bh=iguQ0OuQ7J0C8qOuEmPLouB0CNzR11WpznMfmdHAZeM=; b=NOGvT/mSnIFU0CZVZ81e78sfvRmrit+V80GsbhrTB68SKjFWJGzIAZqPXBikUSKQe8 PYOkYLhj0p7tlxcrqsOmdy84DsbvnG/zitQaVdFTImjZ0NHlC4cV+RAO3NrbPSfVjxX5 29XZUfgmWFk62iEAAGvvefjoWu2bToERZYbxMyzokNetQsvkP4QmS/s1rZrZddmRVMSW PasEnvIqOEqvouPrSN51oa3DF4NlZty3S9twS1N0xgYL2enTahJkcHzRfwop6+0+wVAa gpcea8yK2dDrzyKKLi9pQzTrT3f9jg4D0K9sWu1Jf7MDUtQrD1Zny6uqRODWpj03hxuX CWcg== X-Gm-Message-State: ABUngvcgo7o5MANl/Cy9dXB27/3CPLlvpgtBr6+Me5ZKm215Nmoo8l2z9iPZeg9Zs2rmZw== X-Received: by 10.28.135.84 with SMTP id j81mr1887733wmd.127.1477646563061; Fri, 28 Oct 2016 02:22:43 -0700 (PDT) Original-Received: from jose-ThinkPad-Edge-E330.gmail.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id e5sm7894795wma.10.2016.10.28.02.22.42 for <24620@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 02:22:42 -0700 (PDT) In-Reply-To: <87wpgtqt92.fsf@users.sourceforge.net> Original-References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125090 Archived-At: On Fri, 28 Oct 2016 01:14:49 +0200, npostavs@users.sourceforge.net wrote: > > > That looks pretty good. I think it would be even nicer to use the > `format-spec' function instead of calling `replace-regexp-in-string' > twice. > > Here are the changes: --- dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ dired-aux.el 2016-10-28 09:01:08.413024427 +0200 @@ -1012,11 +1012,15 @@ (t (when (zerop (dired-shell-command - (replace-regexp-in-string - "%o" out-file - (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + (format-spec + (cdr rule) + (list (cons ?o (shell-quote-argument out-file)) + (cons ?i + (mapconcat + (lambda (filename) + (shell-quote-argument + (file-name-nondirectory filename))) + in-files " ")))))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Fri Oct 28 09:01:25 2016